GithubHelp home page GithubHelp logo

Comments (9)

erikzenker avatar erikzenker commented on May 24, 2024

I am thinking about the problem and possible solutions. I don't think that returning the target object in the current actions is the most sophisticated solution to initialize the state. It will make the transition table harder to understand. Two other solutions that came into my mind:

  1. Provide state objects to the state machine object.
    The problem here is that you might not have all parameters to construct the state yet.

  2. Provide a special on_entry event as it is done in the sml
    The action of this event could return the constructed target state

    hsm::state<S1>{} + hsm::on_entry{} / [](auto event, auto source){ return S1{std::string{"Init string"}};}  

from hsm.

erikzenker avatar erikzenker commented on May 24, 2024

@BenjaminW3 can you give me more details on your use case?

from hsm.

BenjaminW3 avatar BenjaminW3 commented on May 24, 2024

In the use case I have in mind, the target state is constructed based on the members of the event leading to the transition to the to-be-constructed target state.
Using on_entry is probably already too late because there the event is already gone.

from hsm.

BenjaminW3 avatar BenjaminW3 commented on May 24, 2024

For reference the rest of my proposal from the other PR discussion:
"I would still allow void returns from actions to use the default constructor. Furthermore, we would have to make sure that only one of the actions in a transition (maybe only the last one?) may return the next state"

from hsm.

erikzenker avatar erikzenker commented on May 24, 2024

Just for the record: I found two bugs while writing the on_entry state initialization integration test (see #103 and #104)

from hsm.

erikzenker avatar erikzenker commented on May 24, 2024

#103 and #104 were fixed

from hsm.

erikzenker avatar erikzenker commented on May 24, 2024

Accidentally, I found out that the sml also supports data members. Maybe because it is not mentioned in the documentation I missed the feature until now.

Just for the record, the user can provide non default initialized states to the constructor of the state machine. I guess if he doesn't they will be default initialized.

The solution is like the first one I already discussed above. And it still has the problem that some states might need data from an event to be constructed.

from hsm.

erikzenker avatar erikzenker commented on May 24, 2024

I added a PR for the feature #118. Would be nice if you can have a look at it.

from hsm.

erikzenker avatar erikzenker commented on May 24, 2024

Merged with #118

from hsm.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.