erikzimmermann / tradesystem Goto Github PK

Hello,

Just discover your plugin, seems to work fine (I'll test deeper and report you problems if any) but I saw the localisation could be much better:

• Move the Language (and maybe Prefix... not sure if it has to be) parameter into Config.yml
• Split Language.yml into language_en.yml and language_de.yml (*), or make a lang/{langcode}.yml

This will help localise your plugin in other languages. It's IMHO cleaner than everything in a single file for admins when there are more than a few sentences. And users could share and contribute their independent languages files easier.

To illustrate what I mean, you can check how Citizens2 manage locales files for example:
https://github.com/CitizensDev/Citizens2/tree/master/main/src/main/resources

You can for example in your reloadConfig() read getConfig().getString("Language"), then load the appropriate file in a list, or something like that. I've already did this king of implementation, I could try to find where it is in my chaos of not finished codes if needed :-)

But this is a suggestion and not a priority ;) Thanks for sharing this plugin with the community!

(*) I think it's better to use ISO code for language filenames, but it's a detail.
Edit: (replaced "files" by "filenames" in this sentence to be more clear).

Edit: Here is an example of a separate lang file for french language.
(fell free to reuse it if you want, it is yours!)

https://www.spigotmc.org/conversations/hello.331509/

https://www.spigotmc.org/resources/...orces-players-to-read-and-accept-rules.53775/

Can you add a option to blacklist items from being traded?

It’s simple, but balance breaking.
Let’s see... Player1 have 5 stacks of items and Player2 have only 2 empty slots in inventory. Player1 initiates trade and offers those 5 stacks for nothing from Player2. Trade goes successfully and Player2 gets those 5 stacks and 3 of them falls on the ground. After a while (1-5 minutes) Player1 gets a copy of those 5 stacks back. How? I dunno but it works exactly as i wrote

Hy,

I really like your plugin, but when an inventory is full, trading is possible. But after the trade, the traded items are gone, due to a full inventory. (dropping wont work for my, dont know why..)

Please add a check for this.
Reguards
Peda1996

UnkownUser » create NPC

Server-Version: 1.12.2 - Spigot

• Nach Eingabe der verschiedenen Items (GMultipleItems) soll die Eingabe des Layout-Namens erfolgen (AnvilGUI)
• Möglichkeit zum zurück und weiterzugehen (im GUI) um spontane Änderungen vorzunehmen
• Tags und Beschreibungen zu den Funktionen (GFunctions) hinzufügen
• Abspeichern neuer Layouts in JSON-Form
• Lesen von JSON-Daten aus einer Config
• Sounds und Hinweise hinzufügen
  • GUI-Wechsel
  • Drücken von Knöpfen
  • Vorm 1. Schritt ein Hinweis, dass im Folgenden die Items im GUI platziert werden sollen
• Hardgecodete Texte in Language-Datei
  • "Back" and "Forward" in "guis" (Editor)
• Die Slots müssen gleichmäßig verteilt sein, sonst soll eine Fehlerausgabe kommen

[05:28:57 INFO]: [TradeSystem] Enabling TradeSystem v1.0.6
[05:28:57 WARN]: Enabled plugin with unregistered PluginClassLoader TradeSystem v1.0.6

Happen when I type /tradesystem reload from the console (default files used to be sure).

I'm using PaperSpigot 1.13.2 BTW (paperclip-451).

Server-Version: 1.12.2 - Spigot
TradeRequest with Sneak + Rightclick

Running latest paperspigot
All plugins are up to date.

[12:57:27 INFO]: > Loading blacklist
[12:57:27 ERROR]: Error occurred while enabling TradeSystem v1.0.5 (Is it up to date?)
java.lang.NoSuchFieldError: PORTAL
at de.codingair.tradesystem.trade.TradeManager.load(TradeManager.java:68) ~[?:?]

Hey there again.

Next to your warp system plugin i've also started using your trading system plugin.
It's really good but there is just 1 thing and it would be better then any other trading plugin i have ever seen.

It's that you can spam players with trades.
I don't really think this is a big problem since there are anti-spam plugins i guess.
But it would be awesome to be implemented into the plugin.

I have already made a request for the WarpSystem Combat fix
But i'm just letting you know that it can become even better ;)

Oh yeah 1 last thingy..
There is an error in the language {i haven't touched the file) i'll show you a screenshot.

[​IMG]
https://gyazo.com/fd00d49548b5f75a7a112ac0e105ff3d

And here are the spam messages:

[​IMG]
https://gyazo.com/30f886b0c32b5e7ce6db5616012fc70b

Source: https://www.spigotmc.org/threads/trade-system-custom-layouts.327308/page-3

Iskandarluqman: "Just a quick suggestion, if you disable in config the money, then in the editor you shouldnt be force :D But that is a way for improvement. I actually looking forward if you can make it have animations? For example in my layout. When both agree then the glass panes in the middle (5 black stained) in this picture will change to yellow one by one until its done countdown. This will give like extra time if they want to change their mind. Maybe in the editor add an option in Functions perhaps called Countdown {Optional}. With optional which mean they can still continue to amigious althought its not been set. Then in the Countdown section, add a 1 second, 2 second , 3 second, 4 second and 5 second. When you press the 1 second, it will just show like the GUI editor, you can select which one you wanna make it the first thing to be change when a countdown begin. Im bad at explaining this, bacisly can you add a countdown which will have an awesome animations? xD"

Let players accept the trade with /trade accept without having to specify the other player name if they only have a pending request (which will be often the case IMHO).

If several request are pending, sent a message "You have several request, you have to specify with which player you accept to trade" or something like that.

Edit: And obviously, same for /trade deny if possible ;)

It's imposible to use unicode in language.yml with any kinds of encoding. Can you please add unicode support?

i.e. GriefPrevention

https://www.spigotmc.org/threads/trade-system-custom-layouts.327308/page-2

GriefPrevention is, as the name suggests, an anti-grief plugin in which players can claim any available land as long as they have sufficient claim blocks. Claim blocks are "virtual", similar to money so it's not a physical item. My suggestion is to allow players to give other players their claim blocks in the same way they can give money.

Plugin Download: https://www.spigotmc.org/resources/griefprevention.1884/
Plugin Source Code: https://github.com/TechFortress/GriefPrevention/

https://www.youtube.com/watch?v=f71dBMnNsmw&feature=youtu.be

Hi, I decided to use your plugin for trading, but I have an error with it (I use version 1.7.10 of Kcauldron, an error from below. Thanks

[01:36:05] [Server thread/INFO]: [TradeSystem] Enabling TradeSystem v1.0.4
[01:36:05] [Server thread/INFO]:
[01:36:05] [Server thread/INFO]: __________________________________________________________
[01:36:05] [Server thread/INFO]:
[01:36:05] [Server thread/INFO]: TradeSystem [1.0.4]
[01:36:05] [Server thread/INFO]:
[01:36:05] [Server thread/INFO]: Status:
[01:36:05] [Server thread/INFO]:
[01:36:05] [Server thread/INFO]: MC-Version: v1_7_R4
[01:36:05] [Server thread/INFO]:
[01:36:05] [Server thread/INFO]: > Loading layouts
[01:36:05] [Server thread/INFO]: ...got 0 layout(s)
[01:36:05] [Server thread/ERROR]: [TradeSystem] Plugin TradeSystem v1.0.4 has failed to register events for class de.codingair.tradesystem.trade.listeners.TradeListener because org/bukkit/event/player/PlayerInteractAtEntityEvent does not exist.
[01:36:05] [Server thread/ERROR]: Error occurred while enabling TradeSystem v1.0.4 (Is it up to date?)
java.lang.NoClassDefFoundError: net/md_5/bungee/api/chat/BaseComponent
at de.codingair.tradesystem.TradeSystem.onEnable(TradeSystem.java:76) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:316) ~[JavaPlugin.class:1.7.10-R0.1-SNAPSHOT]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:368) [JavaPluginLoader.class:1.7.10-R0.1-SNAPSHOT]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:410) [SimplePluginManager.class:1.7.10-R0.1-SNAPSHOT]
at org.bukkit.craftbukkit.v1_7_R4.CraftServer.loadPlugin(CraftServer.java:415) [CraftServer.class:1.7.10-R0.1-SNAPSHOT]
at org.bukkit.craftbukkit.v1_7_R4.CraftServer.enablePlugins(CraftServer.java:349) [CraftServer.class:1.7.10-R0.1-SNAPSHOT]
at net.minecraft.server.MinecraftServer.func_71243_i(MinecraftServer.java:511) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.func_71222_d(MinecraftServer.java:485) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.func_71247_a(MinecraftServer.java:445) [MinecraftServer.class:?]
at net.minecraft.server.dedicated.DedicatedServer.func_71197_b(DedicatedServer.java:336) [lt.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:631) [MinecraftServer.class:?]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_181]

Adding a parameter in config.yml to choose the sound played when:

• Trade is cancelled
• Trade is finished successfully
• A trade request is sent? (and maybe sent a title or something to be sure inattentive player show it)

https://i.gyazo.com/372e448a77ffba0abd33230de76c210e.png