erkens / 2fa-text Goto Github PK

It might be worth noting inside the documentation, that the User entity has to implement the Erkens\Security\TwoFactorTextBundle\Model\TwoFactorTextInterface interface maybe?

Without this, things doesn't work as expected.

Any thoughts @erkens ?

Hi,

Thanks for this bundle.

I have a question regarding the documentation.. It says

First thing to do is make a new service that implements Erkens\Security\TwoFactorTextBundle\Generator\CodeGeneratorInterface so we can actually send a sms or text message. This service can then be used in the configuration as "auth_code_sender":

Is this correct? The bundle already have a CodeGenerator implementation.

Maybe the documentation should read as follows

First thing to do is make a new service that implements Erkens\Security\TwoFactorTextBundle\TextSender\AuthCodeTextInterface so we can actually send a sms or text message. This service can then be used in the configuration as "auth_code_sender":

Thoughts?

Cheers.

Hi. I installed this package but, send error message " Unrecognized option "two_factor_text" under "scheb_two_factor". Available options are "email", "ip_whitelist", "ip_whitelist_provider", "model_manager_name", "persister", "security_tokens", "totp", "two_factor_c
ondition", "two_factor_token_factory". " after "bin/console c:c"

Recently scheb/2fa released v7 to support Symfony 7.

It might just be a "simple" composer.json change, but i haven't looked into it very close.

In your DependencyInjection/TwoFactorTextExtension.php file, line 11 is triggering a deprecation in symfony 7.1:

The "Symfony\Component\HttpKernel\DependencyInjection\Extension" class is considered internal since Symfony 7.1, to be deprecated in 8.1; use Symfony\Component\DependencyInjection\Extension\Extension instead. It may change without further notice. You should not use it from "Erkens\Security\TwoFactorTextBundle\DependencyInjection\TwoFactorTextExtension".

This can be fixed by changing from
use Symfony\Component\HttpKernel\DependencyInjection\Extension;
to
use Symfony\Component\DependencyInjection\Extension\Extension;