Build failed without `--with-lz4-libdir` about erofs-utils

[hsiangkao]

Hi Haruue,
Thanks for reporting this issue. 👍 :)

(Sorry for updating this comment many times, I just want to make the whole thing clearer)
This github repo is only an internal working branch myself.
I rarely check the github issue list since the tradition for all linux kernel related projects is to post related stuffs to their mailing lists.

How about the following modification?
test -z "${with_lz4_libdir}" || LDFLAGS="-L$with_lz4_libdir ${LDFLAGS}"

If you have some time, could you send this patch to erofs mailing list so I can merge it directly?
use git send-email (or proper email client such as mutt) and erofs mailing list address is [email protected]

and see (It's also applicable to erofs-utils since it's a Linux kernel related userspace project):
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Note in particular the requirements for the Developer's Certification of Origin (aka the Signed-off-by tag). That has specific legal meanings (for example, you are certifying that your employer allows
you to contribute to open source projects, or at least, this open source project), so please take a close look at that.

Or I will submit this patch for you (via a reported-by tag since I don't get your signed-off-by tag for this patch....). Boths are fine for me and the first way is better :)

Best regards,
Gao Xiang

[haruue]

test -z "${with_lz4_libdir}" || LDFLAGS="-L$with_lz4_libdir ${LDFLAGS}" should be a better idea. since $LZ4_LIBS would have a -L and an exter -llz4 included.

Since I have sent this patch to [email protected]. I will close this issue now.

[hsiangkao]

Thanks, I have merged it to experimental branch, and I will move it to dev branch tomorrow.