Comments (3)
Hi Haruue,
Thanks for reporting this issue. 👍 :)
(Sorry for updating this comment many times, I just want to make the whole thing clearer)
This github repo is only an internal working branch myself.
I rarely check the github issue list since the tradition for all linux kernel related projects is to post related stuffs to their mailing lists.
How about the following modification?
test -z "${with_lz4_libdir}" || LDFLAGS="-L$with_lz4_libdir ${LDFLAGS}"
If you have some time, could you send this patch to erofs mailing list so I can merge it directly?
use git send-email (or proper email client such as mutt) and erofs mailing list address is [email protected]
and see (It's also applicable to erofs-utils since it's a Linux kernel related userspace project):
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
Note in particular the requirements for the Developer's Certification of Origin (aka the Signed-off-by tag). That has specific legal meanings (for example, you are certifying that your employer allows
you to contribute to open source projects, or at least, this open source project), so please take a close look at that.
Or I will submit this patch for you (via a reported-by tag since I don't get your signed-off-by tag for this patch....). Boths are fine for me and the first way is better :)
Best regards,
Gao Xiang
from erofs-utils.
test -z "${with_lz4_libdir}" || LDFLAGS="-L$with_lz4_libdir ${LDFLAGS}"
should be a better idea. since $LZ4_LIBS would have a -L
and an exter -llz4
included.
Since I have sent this patch to [email protected]. I will close this issue now.
from erofs-utils.
Thanks, I have merged it to experimental branch, and I will move it to dev branch tomorrow.
from erofs-utils.
Related Issues (10)
- [kind reminder] report issues or submiting patches via mailing list
- 这个工具支持生成android sparse格式的镜像么 HOT 8
- big difference between squashfs and erofs size image HOT 3
- A couple of questions on EROFS HOT 6
- Backport erofs to kernel 4.9 HOT 6
- 关于experimental分支的fragments和dedup特性在android上的几个bug HOT 7
- 作者你好,在使用fsck.erofs分析华为emui9.1的system.img时总是提示 HOT 2
- Is it possible to change files without recreating Erofs ? HOT 3
- [fuzzing] global-buffer-overflow
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from erofs-utils.