GithubHelp home page GithubHelp logo

Comments (7)

asuka-mio avatar asuka-mio commented on July 19, 2024

拿gdb连上看了下,也不是死循环,是一个while循环要跑二百万次(以我的测试样本)
https://github.com/hsiangkao/erofs-utils/blob/f3f9a2ce313727a16dd44d5f6cb37882247bdeea/lib/dedupe.c#L79

能否考虑做下simd优化处理

from erofs-utils.

hsiangkao avatar hsiangkao commented on July 19, 2024

hi!刚看到消息,能否在邮件列表报告问题。。这个github我很少翻issue。。

from erofs-utils.

hsiangkao avatar hsiangkao commented on July 19, 2024

拿gdb连上看了下,也不是死循环,是一个while循环要跑二百万次(以我的测试样本)

https://github.com/hsiangkao/erofs-utils/blob/f3f9a2ce313727a16dd44d5f6cb37882247bdeea/lib/dedupe.c#L79

能否考虑做下simd优化处理

dedupe目前是比较费cpu的,后面会考虑多线程处理。但由于历史数据不全,压缩率会有损失。
另外fragment去重已经做了进一步优化。

from erofs-utils.

asuka-mio avatar asuka-mio commented on July 19, 2024

拿gdb连上看了下,也不是死循环,是一个while循环要跑二百万次(以我的测试样本)
https://github.com/hsiangkao/erofs-utils/blob/f3f9a2ce313727a16dd44d5f6cb37882247bdeea/lib/dedupe.c#L79

能否考虑做下simd优化处理

dedupe目前是比较费cpu的,后面会考虑多线程处理。但由于历史数据不全,压缩率会有损失。 另外fragment去重已经做了进一步优化。

嗯我的意思就是这块不知道编译器会不会unroll-loops 或许先用memcmp进行block by block 的对比比较好
AcmeUI/android_external_erofs-utils@2688eff

from erofs-utils.

asuka-mio avatar asuka-mio commented on July 19, 2024

毕竟memcmp在大多数c库下都是simd优化的

from erofs-utils.

hsiangkao avatar hsiangkao commented on July 19, 2024

毕竟memcmp在大多数c库下都是simd优化的

这个位置其实是可以使用类似memcmp的api的,但问题在于memcmp目前无法返回有多少字节匹配,所以不能满足要求。自己写一个或许快一点(比如你说的simd),但目前个人没时间。。

from erofs-utils.

hsiangkao avatar hsiangkao commented on July 19, 2024

I will close the issue (if you'd like to improve, patches are always welcome ;)

from erofs-utils.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.