eshva / evehq-ng.prototype Goto Github PK

Steps to reproduce

1. Open application and ensure it's not logged in.
2. Press Login button in application. An authorization page opens in a browser.
3. Authorize the application.

Bug

An error message appears: The `logger` option function in electron-unhandled threw an error

[Window Title]
Error

[Main Instruction]
The `logger` option function in electron-unhandled threw an error

[Content]
Error: Cannot find module '../net'
    at Module._resolveFilename (module.js:485:15)
    at Function.Module._resolveFilename (C:\Program Files\EveHQ NG\resources\electron.asar\common\reset-search-paths.js:35:12)
    at Function.Module._load (module.js:437:25)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.get [as net] (C:\Program Files\EveHQ NG\resources\electron.asar\browser\api\exports\electron.js:11:16)
    at Object.logExceptionToApi [as logger] (C:\Program Files\EveHQ NG\resources\app.asar\main.js:184:32)
    at handleError (C:\Program Files\EveHQ NG\resources\app.asar\node_modules\electron-unhandled\index.js:28:12)
    at process.on.err (C:\Program Files\EveHQ NG\resources\app.asar\node_modules\electron-unhandled\index.js:70:4)
    at emitOne (events.js:120:20)

[OK]

Expected

• No error appears.
• Application successfully authorized and displays the character page.

Currently all compiled files placed into sources\bin folder. It should be moved on level up to not to mix sources and products.

Sentry

It should be possible to log into rolling up files and console.

Useful links

Introduction to logging in ASP.NET Core
Serilog
Map ILogger to Serilog's Logger after ASP.NET Core 2 logging update
autofac-serilog-integration
Serilog integration for ASP.NET Core 2+

How to update values into appsetting.json?
Microsoft.Extensions.Options Namespace
Microsoft.Extensions.Configuration Namespace
Essential .NET - Configuration in .NET Core

Configgy - doesn't implement options saving but has ideas about encrypting options and pipeline.

Do HttpClient and HttpClientHandler have to be disposed?
Chapter 14. HttpClient
HttpClient, it lives, and it is glorious
YOU'RE USING HTTPCLIENT WRONG AND IT IS DESTABILIZING YOUR SOFTWARE

Configure tsconfig.json and webpack.config.js to allow reference of other modules without relative paths starting from ./ and ../

Currently routing defined on each controller. It should be made centralized to easier new controllers development.

Hence it is a desktop application with a rich UI the UI (SPA) should have ability to log into some kind of log-files for the later support case resolution. My current vision of the solution is some singleton Angular-service that could be injected into components and other classes. This service should send log messages to some web-service log-endpoint.

It should be possible to enable or disable this logging through some kind of UI. The logging is enabled be default from application start and disabled by default as soon as SPA is started.

There should be an easy way for user to send all log altogether to the developers.

NUKE

ESIClient.Dotcore - the .NETStandard 2.0 library for the EVE Swagger Interface

In the future add self-generated library.

There is a few parts to localize:

• Angular SPA
• Local web-service
• Predefined game's static data like skill names

For SPA a good variant is ngx-translate. It supports separate JSON-files for different languages and a tool for localizable strings extraction. It's pretty configurable and seams easy to use in a number of ways.

Local web-service could be localizable in a number of ways but it's desirable to support the same JSON-schema like ngx-translate. Another requirement comes from the fact that the application will have a modular architecture. Hence it should be possible to keep localization resources splitted by modules. There is additional problem that it's easy to get user preferred language in API-controllers but most of strings will be present in different classes. Of course because it is a single-user application I can use some singular configuration object but anyway it's desirable to implement some per-request localization method. As a start: Askmethat-Aspnet-JsonLocalizer

Predefined game's static strings originally comes from SDE by CCP. There are a lot of localized strings and not all of them needed, just a small fracture. They will be required in both SPA and web-service. It's desirable to use the same approaches to get strings, not the third one.

1. Electron application should start without web-service if ran using npm start (if serve specified).
2. It should be possible to run web-service from Visual Studio.
3. Compile main.ts on npm start

The main Electron process program in main.ts file becomes to big and not focused on a single task: start the application. It should be decomposed in relevant number of classes focused on a single task.

The current version 1.8.0 reported by GitHub as vulnerable.

• Remove redundant JSON-files and containing them folders (electron, app) from dotnet publish directory.
• Remove node_modules in the dist folder.
• Remove redundant assets files (background.jpg).

To implement this it's necessary to add static data (SDE) database (SQLite) support.

Sometimes API-service starting a bit too long and application reports about an error. Or the service can halt for some time. There should be a way to handle such situations.

1. Wait the server will come back for some timeout.
2. If it is the forth halt it a row, go to step 4.
3. If it doesn't, restart the service.
4. Inform the user about the problem giving him choices to try again or quit or restart the application.

The API-service should be a singleton and should kill another API-service processes on start.