GithubHelp home page GithubHelp logo

Comments (5)

sw005320 avatar sw005320 commented on May 27, 2024

Stage 5 In these lines, there are ${_suf}${dset}/${train_set} and ${_suf}${dset}/${train_set}_sp. Since dset comes from a previous for loop, I expect it should be removed.

I think this sounds good to me.

Stage 6 and Stage 7 lm_train_text is data/${train_set}/text.${tgt_case}.${tgt_lang} in the default run.sh, which does not work in Stage 6. This is because ${train_set}/text.${tgt_case}.${tgt_lang} is now included in only dump/extracted if you use speed perturbation. I can set lm_train_text to dump/extracted/wavlm_large/layer21/${train_set}/text.${tgt_case}.${tgt_lang}, but do you have any simpler ideas? A similar problem happens in the stage 7 with src_bpe_train_text and tgt_bpe_train_text.

I think feeding dump/extracted/wavlm_large/layer21/${train_set}/text.${tgt_case}.${tgt_lang} sounds good to me.
One option would be to get the configurations (e.g., wavlm_large and layer21) from the config file, but it is tricky.

@simpleoier, do you have any idea?

from espnet.

simpleoier avatar simpleoier commented on May 27, 2024

Hi @YoshikiMas, thanks for noticing the problem.
Yeah, I agree with the suggested change in stage 5.
For the lm_train_text, we can simply use data/${train_set}/text, the same as what is used in asr1. We do not need to use the pattern of ${src_case} or ${tgt_case}.
I'll prepare a PR for this after I finish the test.

from espnet.

sw005320 avatar sw005320 commented on May 27, 2024

For the lm_train_text, we can simply use data/${train_set}/text, the same as what is used in asr1. We do not need to use the pattern of ${src_case} or ${tgt_case}. I'll prepare a PR for this after I finish the test.

I see; this is an LM for the natural text, not a speech token LM.

from espnet.

simpleoier avatar simpleoier commented on May 27, 2024

Yes, exactly!

from espnet.

YoshikiMas avatar YoshikiMas commented on May 27, 2024

We do not need to use the pattern of ${src_case} or ${tgt_case}.

Thank you for pointing out! I confirmed that data/${train_set}/text is the same as dump/extracted/.../text.${tgt_case}.${tgt_lang}.

Maybe only the issue is src_bpe_train_text. Of course, we can directly specify it as Shinji suggested for lm_train_text.

from espnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.