esukhia / bophono Goto Github PK

Using bophono with pip install bophono fails for two reasons:

• dependency to pypandoc is missing
• resources are missing / inconsistent source version published

Since the module does seem to work when installed from git,

please consider republishing a complete version of bophono.

https://github.com/Esukhia/bophono/blob/master/bophono/data/exceptions-kvp.csv#L117C1-L117C9

སློ་བཟང་ should be བློ་བཟང་

When installing bophono from pip, it fails on import with the following trace:

Traceback (most recent call last):
  File "/home/drupchen/PycharmProjects/publishers-cleanup/match_existing_place_RID.py", line 4, in <module>
        import bophono
  File "/home/drupchen/.local/lib/python3.6/site-packages/bophono/__init__.py", line 5, in <module>
        from .apitochinese import *
  File "/home/drupchen/.local/lib/python3.6/site-packages/bophono/apitochinese.py", line 7, in <module>
        zhuyin_csv = get_trie_from_file(_get_trie_path("zhuyin.csv"), "zhuyin_csv")
  File "/home/drupchen/.local/lib/python3.6/site-packages/bophono/sdtrie.py", line 131, in get_trie_from_file
        with open(filename, newline='', encoding="utf8") as csvfile:
FileNotFoundError: [Errno 2] No such file or directory: '/home/drupchen/.local/lib/python3.6/site-packages/bophono/data/chinese/zhuyin.csv'

there should be options to chose the output of the different tones. The current situation is that we have two tones that correspond to the phonology, but the realization is more complex and described on page 36 of the MST

• pypi does not work at all
• If install from git, then the following error will come:

FileNotFoundError: [Errno 2] No such file or directory: '/Users/upstairs/opt/miniconda3/envs/wip/lib/python3.8/site-packages/bophono/data/chinese/zhuyin.csv'

There should not be static files as dependencies for packages unless there is an exceptional reason for it. When that is the case, the data should not be inside the package, but pulled from github or other repository.

The current system where they are all in one makes it very difficult to read and easy to make mistakes when editing. So the proposal is that we move into a system where each scheme lives in their own sub-folder of schemes folder, and has standard set of files:

• SchemeName.py
• roots.csv
• ends.csv
• exceptions.csv

It seems like it's can not turn some Tibetan words to IPA, such as 'ཧྥེ', 'པའིམ', and 'འོདད'.

Right now, looks like Sanskritization is ignored entirely, so basically, mantras are not phonetized.

Looks like a small addition with big value (as otherwise manual work is still needed in the end).

How would we implement this?

This file seems to be required to run the command given in README.md. But there is not even such a folder called data.

What is pandoc used for in this library? Given that we are just converting string to another string, it seems that no such package is needed?

Generally speaking, python packages should not have dependencies that are not python. When there is such a thing, it should be because a vitally important capability is impossible without such dependency. It should never be because of convenience or habit.