GithubHelp home page GithubHelp logo

Is the Dictionary type necessary? about rlp HOT 2 CLOSED

s1na avatar s1na commented on June 10, 2024
Is the Dictionary type necessary?

from rlp.

Comments (2)

alcuadrado avatar alcuadrado commented on June 10, 2024

I think Dictionary is not only not needed, but incorrect. Calling encode({a: 1123}) throws invalid type.

I believe it was added in e81acfd9571 when trying to solve #35. TS support for recursive types is non-obvious, and while googling about it I got to this comment by Anders Hejlsberg
which looks almost the same as the original types.ts. This was probably copy-pasted and accidentally left here.

from rlp.

s1na avatar s1na commented on June 10, 2024

Fixed via #74

from rlp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.