GithubHelp home page GithubHelp logo

euler-contracts's People

Contributors

dglowinski avatar hoytech avatar k06a avatar kasperpawlowski avatar najienka avatar tanyaroze avatar tarieuler avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

euler-contracts's Issues

Error in `integration with uniswap3 core` test: `Timeout of 20000ms exceeded.`

Here's another flaky test:

 298 passing (10m)
  1 failing

  1) uniswap3 twap
       integration with uniswap3 core:
     Error: Timeout of 20000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/tmp/ext-test-Euler-X7BOE6/ext/test/uniswap-integration.js)
      at listOnTimeout (node:internal/timers:557:17)
      at processTimers (node:internal/timers:500:7)

I've seen several instances of it in the last 3 days: 966585, 966481, 965865, 965823, 965567.

Does not seem to be a race condition like in #93. Or at least TEST_SLEEP does not make it easily reproducible - I've only seen it in CI so far and not in local runs.

Flaky tests failing with `Error: equals failure: x was not y +/- z`

I'm seeing some tests fail randomly from time to time. It seems that they might not be deterministic enough or there could be a bug:

https://app.circleci.com/pipelines/github/ethereum/solidity/21640/workflows/e8f4e019-264e-4572-bab7-177ef32c5c6a/jobs/948090

  297 passing (11m)
  1 failing

  1) reserves
       reserves:
     Error: equals failure: 0.000000013484437479 was not 0.000000015 +/- 0.000000001
      at equals (test/lib/eTestLib.js:1150:19)
      at TestSet._runTest (test/lib/eTestLib.js:912:17)
      at Context.<anonymous> (test/lib/eTestLib.js:851:21

https://app.circleci.com/pipelines/github/ethereum/solidity/21639/workflows/be150d7f-d0b1-4730-a26f-e6a5a4316fe7/jobs/948031

297 passing (7m)
  1 failing

  1) transfer dTokens
       lower decimals:
     Error: equals failure: 0.000000008000000102 was not 0.000000008 +/- 0.0000000000000001
      at equals (test/lib/eTestLib.js:1150:19)
      at TestSet._runTest (test/lib/eTestLib.js:912:17)
      at Context.<anonymous> (test/lib/eTestLib.js:851:21)

I'm actually compiling contracts with the latest compiler (the whole point for me is to test the compiler) and adjusting optimizer settings, which could theoretically be the cause but most of the time all tests pass so I think that's unlikely. I think that a problem is probably in the tests.

Error in `stake permit` test: `AssertionError: expected false to equal true`

Recently, this test started failing:

 338 passing (7m)
  1 failing

  1) staking
       stake permit:

      AssertionError: expected false to equal true
      + expected - actual

      -false
      +true
      
      at Object.cb (test/eulStakes.js:522:55)
      at TestSet._runAction (test/lib/eTestLib.js:1191:13)
      at TestSet._runTest (test/lib/eTestLib.js:1044:26)
      at Context.<anonymous> (test/lib/eTestLib.js:1016:21)

1068599 and 1068676 are two examples of the problem in CI, but it is also reproduced in a local run:

git clone https://github.com/euler-xyz/euler-contracts
cd euler-contracts/
npm init
npm --save-dev install hardhat
npx hardhat test test/eulStakes.js

The problem seems to be related to 4 occurrences of et.expect(result.domainSeparatorMatch).to.equal(true); in file eulStake.js.
When true is changed to false, the test is successful.

[Feature request] add staking/rewards on the EulerSimpleLens

Currently, there's no method on the Simple Lens to fetch a user's EUL balance. I believe its possible to get this information from the EulStakes contract, however, this is not explicitly advertised in the docs with examples.

Is it possible to add a simple function on the lens contract for non-technical users to query their EUL balance easily?

Flaky test for EUL distributor: `expected 'incorrect data length (argument=null,…' to include 'proof invalid/expired'`

This test failed today in 968204:

309 passing (9m)
  1 failing

  1) EUL distributor
       invalid claim inputs:
     AssertionError: expected 'incorrect data length (argument=null,…' to include 'proof invalid/expired'
      at Object.cb (test/eulDistributor.js:266:42)
      at TestSet._runAction (test/lib/eTestLib.js:1051:13)
      at TestSet._runTest (test/lib/eTestLib.js:904:26)
      at Context.<anonymous> (test/lib/eTestLib.js:878:21)

I have only seen it fail once so far and after rerunning (968410) it passed.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.