evadogstar / qvm-screenshot-tool Goto Github PK
View Code? Open in Web Editor NEWQubes Os Screenshot Tool. Provice functionality to upload screenshots to other AppVMs and to imgurl service
License: MIT License
qvm-screenshot-tool's People
Contributors
Stargazers
Watchers
Forkers
jpl1 heinrich-ulbricht qubesos-contrib alexfinkelshtein zezadas caputomarcos honzahosek bakeromsoqvm-screenshot-tool's Issues
Add flag support
First of all, thank you for this tool, it's a huge time saver!
I have a suggestion for further time-saving though. When using this tool, I often just select 'Region or Window' in the first menu. Doing this each time is a bit tedious. Would it be possible to add some flags like -r and --region-only so that we can skip the first menu and start taking a screenshot immediately?
Thanks!
Syntax Error
I'm getting an error when I try to run ./qvm-screenshot-tool
./qvm-screenshot-tool.sh: line 7: syntax error near unexpected token `newline'
./qvm-screenshot-tool.sh: line 7: `<!DOCTYPE html>'
QubesOS-contrib
Hello, @evadogstar ! Thank you again for contributing this package to @QubesOS-contrib. We've noticed that you've done further development work on this package, and we'd like to make your work available to Qubes users. Would you please submit an update pull request at your earliest convenience? Thank you!
Clipboard doesnt work with this tool
Hello,
All functions work well with this except copying the screenshot to another appvm clipboard, anyone else have this issue?
Moving file with example terminal commandfails
After downloading the tool to my 'personal' vm I typed the following into my dom0 terminal window:
qvm-run --pass-io personal 'cat /path/to/qvm-screenshot-tool.sh' > /home/user/Pictures/qvm-screenshot-tool.sh
response:
bash: /home/user/Pictures/qvm-screenshot-tool.sh: No such file or directory
This is on a new Qubes 3.1 installation with all vm templates updated.
I'm new to linux, so I'm sure the problem is with my interpretation of the provided CLI command.
Suggestions
I am using this script on my Qubes 4.0.
I wanted to add a hotkey for a region screenshot, bypassing the first dialog.
However, scrot misbehaves and no screenshot is taken if the command is executed from the hotkey.
My solution was:
Replace scrot with xfce4-screenshooter. It is natively installed in dom0 and does not have this problem
In particular, replace this line:
scrot -s -b "$destination"
for
xfce4-screenshooter -r -o cat > "$destination"
Possible drawback:
xfce4-screenshooter can't screenshot a window by clicking on it.
Personally, I am more than OK with this tradeoff
At the very least it would be nice to add xfce4-screenshooter as a shortcut-safe option (at least for 4.0 users, I don't know if maim has this problem or not).
Some other suggestions I have:
Add short handles for all or most of the options (-f for --fullscreen, -u for --upload-to-appvm-only, etc)
Make it possible to blacklist certain VMs from upload choices. This would make the VM selection more straightforward for users, with fewer options to chose from each time a screenshot is taken.
I implemented this by editing this line:
choiceappvm=$(qvm-ls --raw-list |sed 's/\([^ ]*\)/FALSE \1 /g')into
choiceappvm=$(qvm-ls --raw-list | sed -e "$(sed 's:.*:s/^&$//:' $DOM0_SHOTS_DIR/blacklist)" | sed '/^$/d' | sed 's/\([^ ]*\)/FALSE \1 /g')(this code is based on the QubesOS-contrib fork, but the same logic should apply here)
And a final suggestion to edit this issue for the 1697th time:
Add an option to copy the screenshot to the app VM's clipboard.
UX Audit
Howdy! Marek pointed me towards this repo, with the sidenote that they're hoping to incorporate this into a future version of Qubes, OEM.
I'm working on some UX stuff for the Qubes team, and wanted to know if I could get a walkthrough of this tool from one of its contributors, at some point. I'm in Oregon, USA and can do this remote; and am used to doing Qubes walkthroughs with developers using a handheld phonecam to fudge a "Screenshare" from their end.
From there, would there be an openness to implement suggested usability enhancements—or, to do some user testing? For reference: I lead UX for SecureDrop right now, and most of my GH viewable contribs, are in this repo: https://github.com/freedomofpress/securedrop-ux
I don't code, and I barely git or do any CLI stuff—design and research for users are my skill domains.
Thanks! :) nina
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.