evaneos / berthe Goto Github PK

selectByFetcher returns ids of element that have their filtered column to the filtered value.

Why does the implementation of TYPE_IN is forces by the Fetcher instead of being left to the FetcherQueryBuilder ? I'd like to implement the TYPE_IN in mongo but I can't :(

https://github.com/Evaneos/berthe/blob/master/src/Berthe/Fetcher.php#L198

Problème

Et ça nous empêche de chercher les Facets par filtres de type tag, parce qu'ils ont deux formes de sérialisation valables.

On doit chercher une valeur de slug de tag soit en tant que string directement (facet.filter.travel-type), soit en tant que valeur de la propriété slug d'un objet (facet.filter.travel-type.slug).

Le query builder gérant un OR comme un AND, on ne peut obtenir de résultats, puisque le filtre de type tag est sérialisé d'une seule façon à la fois.

Exemple

La requête suivante ne renvoie pas de résultat, alors qu'on devrait en avoir :
https://pro.evaneos.com/api/v2/facets?page=1&travelTypes=selfdrive&format=json

Idea

The idea would be to add 3 DAL classes for mongo support

• A MongoReader implementing Reader
• A MongoWriter implementing Writer
• A FetcherMongoQueryBuilder implementing FetcherQueryBuilder

Problem

1. The Reader interface is a little bit too specific for mongo. I'm thinking about two methods.
   • getVOFQCN : we might want to retrieve mongo data in the array form. No VO needed.
   • setTranslator: It doesn't make any sens to have translatable field in mongo document (in the form of external ids).
2. The operations always happen on a collection. The idea would be to inject directly the collection to the reader & writer. However, since the DI is not yet lazy, this would mean instantiate the collection on each bootstrap.

Solution

1. Move those two methods into the ABstractReader
2. Wait for the new version of the DI

Problem :

Sometimes, we want to get ressource by ids. And sometimes, when those ids come from the outside (MongoDB, LocalStorage, whatever), we cannot garanty consistency. This means that sometimes, the ressource associated to one of the ids does not exists anymore.

For now, the default behaviour of getById is to throw an exception.

But what if I still want to have the other ids ? For composition for instance...

Now, I'm obliged to add a method getByIdsIn in the service of my ressource. It sucks.

Solution

What I propose, is to add a getByIdsIn in the AbstractService, which doesn't throw an Exception when one of the id is missing.

What do you think ?

In AbstractService.php

    /**
     * (non-PHPdoc)
     * @see \Berthe\Service::save()
     */
    public function save($object, $data = null) {
        $object = $this->builder->updateFromArray($object, $data);

        if (!$this->manager->save($object)) {
            throw new \FunctionalErrorException('Creation failed!', 500);
        }

        return $object;
    }

In Interface Builder.php

    public function updateFromArray($object, array $data = array());