everest3d / cpp-btree Goto Github PK

A bug report mentioned that performance really was better for them, for their 
workload, with >= 256 values per node.  So I did this, ...

Branch name:

Purpose of code changes on this branch:
Fixed a problem report.

When reviewing my code changes, please focus on:
FYI, mostly.

After the review, I'll merge this branch into:
/trunk

[deleted issue]

OCD apostrophe correction ("it's" == "it is").

What steps will reproduce the problem?
1. Compile using MSVC 2010


What is the expected output? What do you see instead?

Compilation should succeed.

What version of the product are you using? On what operating system?

Windows 7 + MSVC 2010 (SP1)

Please provide any additional information below.

Compile error:

btree.h(1401) : error C2064: term does not evaluate to a function taking 2 
arguments

That is the 

COMPILE_ASSERT(
      sizeof(key_compare_checker(key_compare_helper()(key_type(), key_type()))) ==
      sizeof(big_),
      key_comparison_function_must_return_bool);

What steps will reproduce the problem?
1. Use MSVC 2010 to compile any file using btree.h

What is the expected output? What do you see instead?
Should compile, but fails because ssize_t is not known.


What version of the product are you using? On what operating system?
Windows 7 + MSVC 2010 (with matching SDK)

Please provide any additional information below.

Can be fixed by a patch to btree.h like:

#if defined(_MSC_VER)
#include <BaseTsd.h>
typedef SSIZE_T ssize_t;
#endif

This should work with MSVC versions >= 2010, older ones might not work anyway 
because of missing C++11 support.

Other issues remain, will open separate issues here for them.

Compiling with: clang version 3.3 (trunk 173428)

Simplified, thanks.