everlookneversee / asfr Goto Github PK

Description

An unused variable take up space in the code, and can lead to confusions. It should be removed. If this variable is necessary, name the variable _ or start the name with unused or _unused.

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/EverLookNeverSee/FRP/issue/PYL-W0612/occurrences/

I am going to store images encodings to a file or database(SQL or NoSQL) like mongodb in order to speed up recognition time for large amount of images(5000 instances or more).

if the statistics directory does not exist, create one at cold start

Description

Opening a file using with statement is preferred as function open implements the context manager protocol that releases the resource when it is outside of the with block. Not doing so requires you to manually release the resource.

Occurrences

There are 2 occurrences of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/EverLookNeverSee/FRP/issue/PTC-W0010/occurrences/

encoder function returns an index error while encoding loaded picture as shown below:

Description

The else / elif block here is unnecessary because the leading if block has a continue statement. This doesn't mean you cannot use it, but it is recommended to refactor this else / elif statement for a better readability. Bad: ```python def classify_number(x): for num in range(x): if x % …

Occurrences

There is 1 occurrence of this issue in the repository.

See all occurrences on DeepSource → deepsource.io/gh/EverLookNeverSee/FRP/issue/PYL-R1724/occurrences/

Hi @moharnadreza
csv_reader function was deleted on one of my previous pull requests, but you called it as an exposed function in your index.js file:
https://github.com/EverLookNeverSee/ASFR/blob/1b7ae38df61d04a936aa77fe0a9483825f0cb7d0/web/index.js#L91-L97

It was supposed to you create a function to read and display csv files.

Performance improvement of encoder function using options below:

• using numba jit decorator
• using ThreadPoolExecutor located in concurrent.futures

https://github.com/EverLookNeverSee/FRP/blob/056ae6108166d91834a53a22811fd113d0876152/frp/encoder.py#L9