evgenbabenko / incode-app Goto Github PK

it can be moved to static propTypes, but be aware of using relevant babel preset (as well as defaultProps).

Consider memoizing this filter result. Look at the samples in the documentation. You'll like it ;)

Consider using redux bindActionCreators https://redux.js.org/api-reference/bindactioncreators

...

Please avoid iterating the whole list of entities (tasks) to update only one of them.

https://github.com/EvgenBabenko/incode-app/blob/f/async/src/containers/Auth.jsx#L10

Please take a look at binding strategies in React and their pros/cons.
Take thoughtfully this article https://medium.com/@charpeni/arrow-functions-in-class-properties-might-not-be-as-great-as-we-think-3b3551c440b1

Summary:

The initialization of arrow functions in class properties are transpiled into the constructor.
Arrow functions in class properties won’t be in the prototype and we can’t call them with super.
Arrow functions in class properties are much slower than bound functions, and both are much slower than usual function.

Try to avoid componentDidUpdate as much as possible. Use it only in case you need to do something after EVERY component rerender (DOM has been updated): for example you're using any 3rd-party UI libs like charts, maps or whatever.
There is a recommendation to use it in case you need some actions to perform if props have been changed, but it's also dangerous bc you may come into an infinite loop by occasional using setState somewhere inside.
Please take a look at getDerivedStateFromProps approach https://reactjs.org/docs/react-component.html#static-getderivedstatefromprops AND read about it thoughtfully (including warnings and better alternatives).