evolution-gaming / resource-pool Goto Github PK

I have some questions and suggestions for improving the code. Feel free to ignore stylistic suggestions because they're subjective.

1. I don't think we should expose IntHelper as a part of public API, I'd mark it as private[resourcepool].

2. Do we really need implicits in our public API (IntHelper, ResourcePoolOps)? IMO introducing an implicit is justified only if it's going to be used a lot of times. How many times a user is going to construct a pool in his code? Probably once or twice. So I think it's much easier for the user to have an explicit method and not think about what they need to import.

3. If I understand correctly, cancellation works differently for ResourcePoolOps.resource than for ResourcePool.get. cats.effect.Resource.apply makes acquire and release uncancelable. I think this change in cancellation semantics can be a surprise for the users, so I'd mention it in the scaladoc for ResourcePoolOps.resource.