GithubHelp home page GithubHelp logo

Comments (4)

sprunk avatar sprunk commented on May 31, 2024

Does this reproduce? Looks like a download bug.

from evolution-rts.

ForbodingAngel avatar ForbodingAngel commented on May 31, 2024

I ended up removing CUS because there was no work being done to fix the issues in the main repo for it. Gajop acted interesting in fixing it, but I never heard anything about it, so I ended up removing it entirely. It should be noted that I did hack together a fix, but I am not comfortable with bandaid fixes that are incompatible with upstream. Had I known that CUS would remain broken and untouched for all this time I might have reconsidered removing it entirely.

This is the main repo:
https://github.com/jk3064/Custom-Unit-Shader-Framework

This is Gajop's fork:
https://github.com/gajop/Custom-Unit-Shader-Framework

This is where I addressed it on the spring forums:
https://springrts.com/phpbb/viewtopic.php?t=34618

Here is a pull request after cannibalizing from ZK:
gajop/Custom-Unit-Shader-Framework#1

And here is my fork of the repo that I don't remember making but apparently contains some fixes:
https://github.com/ForbodingAngel/Custom-Unit-Shader-Framework

Sprung, since apparently neither JK nor Gajop have any intention of fixing CUS in a uniform and working way, would you be interested in abstracting CUS from ZK (because it is the most likely to have up to date fixes and we can verify at the outset that it is working properly) and putting it in the Spring Helper Projects ( https://github.com/Spring-Helper-Projects/ ) organization?

from evolution-rts.

sprunk avatar sprunk commented on May 31, 2024

I'd be interested in helping but it's going to be fairly low priority (I don't expect to have the spare time until the Christmas break).

from evolution-rts.

ForbodingAngel avatar ForbodingAngel commented on May 31, 2024

Yeah that's no worries. I gave up on CUS a long time ago. I think it would be beneficial for it to be easily implementable in projects, but for myself, while it would be nice, I'm not particularly clamoring for it. That said, I think it needs to be done just for the sake of doing it is a positive movement.

from evolution-rts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.