GithubHelp home page GithubHelp logo

ewyboy / cha-s Goto Github PK

View Code? Open in Web Editor NEW
3.0 2.0 1.0 96.84 MB

Minecraft mod lets you craft saddle and horse armour.

Home Page: https://www.curseforge.com/minecraft/mc-mods/cha-s/

License: MIT License

Java 100.00%
mod modded modded-minecraft minecraft-forge minecraft-fabric forge-mod forge fabric

cha-s's People

Contributors

ewyboy avatar

Stargazers

 avatar  avatar  avatar

Watchers

 avatar  avatar

Forkers

crasycookie

cha-s's Issues

1.16.x version actually requires 1.16.4

When I try to load with forge 1.16.3, I get the error "Mod file CraftableHorseArmour-1.16.X-1.4.0.jar needs language provider javafml:35 or above to load. We have found 34.1" This could be from a dependency listed in the mods.toml file.

Missing config files?

Downloaded and ran 1.3 in 1.12.2. Recipes appear just fine. I shut down Minecraft and wanted to change the recipes to the old ones, however, I do not see the config file in my .minecraft/config folder.

[1.16.2] crashes Minecraft on startup

Just a heads up, with the latest version of Forge for 1.16.2-forge-33.0.61 I also tested it on 1.16.2-forge-33.0.55 it would fail with this message:

10Sep2020 17:11:22.370] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: net.minecraftforge.fml.loading.moddiscovery.InvalidModFileException: Missing License, please supply a license. (craftablehorsearmour-1.3.jar)
[10Sep2020 17:11:22.373] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at net.minecraftforge.fml.loading.moddiscovery.ModFileInfo.lambda$new$2(ModFileInfo.java:71)
[10Sep2020 17:11:22.373] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at net.minecraftforge.fml.loading.moddiscovery.ModFileInfo$$Lambda$253/1178587240.get(Unknown Source)
[10Sep2020 17:11:22.374] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.util.Optional.orElseThrow(Optional.java:290)
[10Sep2020 17:11:22.375] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at net.minecraftforge.fml.loading.moddiscovery.ModFileInfo.(ModFileInfo.java:71)
[10Sep2020 17:11:22.375] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at net.minecraftforge.fml.loading.moddiscovery.ModFileParser.modsTomlParser(ModFileParser.java:62)
[10Sep2020 17:11:22.375] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at net.minecraftforge.fml.loading.moddiscovery.ModFile$$Lambda$233/1819940427.build(Unknown Source)
[10Sep2020 17:11:22.376] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at net.minecraftforge.fml.loading.moddiscovery.ModFileParser.readModList(ModFileParser.java:46)
[10Sep2020 17:11:22.377] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at net.minecraftforge.fml.loading.moddiscovery.ModFile.identifyMods(ModFile.java:114)
[10Sep2020 17:11:22.378] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer.discoverMods(ModDiscoverer.java:116)
[10Sep2020 17:11:22.378] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at net.minecraftforge.fml.loading.FMLLoader.beginModScan(FMLLoader.java:213)
[10Sep2020 17:11:22.378] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at net.minecraftforge.fml.loading.FMLServiceProvider.runScan(FMLServiceProvider.java:107)
[10Sep2020 17:11:22.379] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at cpw.mods.modlauncher.TransformationServiceDecorator.runScan(TransformationServiceDecorator.java:114)
[10Sep2020 17:11:22.380] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at cpw.mods.modlauncher.TransformationServicesHandler.lambda$runScanningTransformationServices$8(TransformationServicesHandler.java:115)
[10Sep2020 17:11:22.380] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at cpw.mods.modlauncher.TransformationServicesHandler$$Lambda$181/597307515.apply(Unknown Source)
[10Sep2020 17:11:22.380] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:267)
[10Sep2020 17:11:22.381] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.util.HashMap$ValueSpliterator.forEachRemaining(HashMap.java:1612)
[10Sep2020 17:11:22.381] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:512)
[10Sep2020 17:11:22.382] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:502)
[10Sep2020 17:11:22.382] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
[10Sep2020 17:11:22.387] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
[10Sep2020 17:11:22.388] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
[10Sep2020 17:11:22.388] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at cpw.mods.modlauncher.TransformationServicesHandler.runScanningTransformationServices(TransformationServicesHandler.java:116)
[10Sep2020 17:11:22.388] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at cpw.mods.modlauncher.TransformationServicesHandler.initializeTransformationServices(TransformationServicesHandler.java:63)
[10Sep2020 17:11:22.389] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at cpw.mods.modlauncher.Launcher.run(Launcher.java:75)
[10Sep2020 17:11:22.389] [main/INFO] [STDERR/]: [java.lang.ThreadGroup:uncaughtException:1052]: at cpw.mods.modlauncher.Launcher.main(Launcher.java:65)

v1.3 for 1.16 Forge [2.04 KB - Sep 11, 2020] failed but 'other' v1.3 for 1.16 [4.59 KB - Jun 30, 2020] Forge works after adding 'license="..."' in 'mods.toml'

Hi,
As stated in the title, v1.3 for 1.16 Forge [2.04 KB - Sep 11, 2020 - filename 'CHAS v1.3 for 1.16 Forge.jar'] failed but the 'other' v1.3 for 1.16 Forge [4.59 KB - Jun 30, 2020 - filename 'craftablehorsearmour-1.3.jar'] works after adding 'license="..."' in 'mods.toml' (ie. it comes up with the error 'missing license info').

Thanks for the great mod btw,
M.
EDIT: I'm using minecraft -1.16.3 & forge-34.1.5
EDIT2: I tested only with JEI; ie. I did not use the crafting bench to test the recipes.

[Bug] Conflicting crafting recipes

Minecraft Version

1.20.4

Forge Version

N/A

Mod Version

1.10

Describe the bug

There are two different, conflicting crafting recipes for a saddle on the (Curseforge) mod page. One image shows string as part of the recipe, the other image omits the string. It is unclear which one is the correct recipe, or if both are intended to be functional.

How to reproduce

Go to https://www.curseforge.com/minecraft/mc-mods/cha-s and scroll down to the last image on the page (also see attached images below).

Link to crashlog [If Applicable]

N/A

Screenshots / Images

image
image

[Forge Version Check/WARN]: Failed to process update information

Error:

[09:44:30] [Forge Version Check/INFO]: [craftablehorsearmour] Starting version check at http://myurl.me/
[09:44:30] [Forge Version Check/WARN]: Failed to process update information
com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 1 path $
	at com.google.gson.Gson.fromJson(Gson.java:899) ~[gson-2.8.0.jar:?]
	at com.google.gson.Gson.fromJson(Gson.java:852) ~[gson-2.8.0.jar:?]
	at com.google.gson.Gson.fromJson(Gson.java:801) ~[gson-2.8.0.jar:?]
	at com.google.gson.Gson.fromJson(Gson.java:773) ~[gson-2.8.0.jar:?]
	at net.minecraftforge.fml.VersionChecker$1.process(VersionChecker.java:214) [?:?]
	at net.minecraftforge.fml.VersionChecker$1$$Lambda$12089/1931026536.accept(Unknown Source) [?:?]
	at java.lang.Iterable.forEach(Iterable.java:75) [?:1.8.0_51]
	at net.minecraftforge.fml.VersionChecker$1.run(VersionChecker.java:157) [?:?]
Caused by: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 1 path $
	at com.google.gson.stream.JsonReader.beginObject(JsonReader.java:385) ~[gson-2.8.0.jar:?]
	at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:183) ~[gson-2.8.0.jar:?]
	at com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:145) ~[gson-2.8.0.jar:?]
	at com.google.gson.Gson.fromJson(Gson.java:887) ~[gson-2.8.0.jar:?]
	... 7 more

latest log: Here
Highlighted code: Here

Environment

  • Minecraft 1.15.2
  • Forge 31.2.36
  • Craftable Horse Armour & Saddle [CHA&S] v3a

Steps to reproduce

  1. Click play in Twitch App
  2. Click play in Minecraft Launcher
  3. Create a new world
  4. Enter world
  5. Exit world

Missing License on github

You included a custom Open License on curseforge.
If you include it on github, it would allow others to safely work with your mod because without it's in a grey zone, I think.
Can be a blank file or *.md file named "LICENSE"

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.