The haystack-client-java from expediadotcom

haystack-client-java's People

Contributors

Stargazers

Watchers

haystack-client-java's Issues

Version number is not correct.

Version 0.2.8 has already been released to maven central: https://search.maven.org/artifact/com.expedia.www/haystack-client-core/0.2.8/jar therefore the version number in the pom.xml files should be 0.2.9-SNAPSHOT.

LongIdGenerator is not properly supported

The LongIdGenerator was introduced in commit #b93f6685 however there are still numerous places in the code that assume that traceId is a UUID:

For example in the TextMapPropagator#extract(TextMap carrier) method the following code exists (which assumes the traceId, spanId and parentId are all UUID's):

        SpanContext context = new SpanContext(UUID.fromString(traceId),
                                              UUID.fromString(spanId),
                                              parentId == null ? null : UUID.fromString(parentId),
                                              true);

When the LongIdGenerator is used (in a client) the following error occurs:

Error handling a request: 9747e8d6c092bd0b
! java.lang.IllegalArgumentException: Invalid UUID string: 1560033070049436460
! at java.util.UUID.fromString(UUID.java:194)
! at com.expedia.www.haystack.client.propagation.TextMapPropagator.extract(TextMapPropagator.java:101)
! at com.expedia.www.haystack.client.propagation.TextMapPropagator.extract(TextMapPropagator.java:30)
! at com.expedia.www.haystack.client.Tracer.extract(Tracer.java:185)
! at com.expedia.www.haystack.client.Tracer.extract(Tracer.java:43)
! at io.opentracing.contrib.jaxrs2.server.ServerTracingFilter.parentSpanContext(ServerTracingFilter.java:99)
! at io.opentracing.contrib.jaxrs2.server.ServerTracingFilter.filter(ServerTracingFilter.java:68)
! at org.glassfish.jersey.server.ContainerFilteringStage.apply(ContainerFilteringStage.java:132)
<snip>

This can be easily replicated by running the example in https://github.com/ExpediaDotCom/haystack-dropwizard-example

There is also a reference to UUID.randomUUID() on Line 327 in Tracer.java which should be replaced by tracer.idGenerator.generate()

Recommend Projects