exterex / noaa

Python API for NOAA climate data

Hi 👋, I'm Andreas Sagen

A passionate toxicology student from Norway. Work in molecular and cellular toxicology on in vitro studies of the immunotoxic effects from exposure to nanoplastics.

Connect with me:

Languages and Tools:

Profile summary:

noaa's Issues

Automate package release

Expand on the pipeline in .github/workflows/release.yml to automatically put wheel in the release document. A possible actions could be: actions/upload-release-asset.

Fully unittest the code

Add tests to automate testing in .github/workflows/release.yml.

Coverage

Add coverage testing to Github actions.

Bad date parameters in `get_data`

• Version: main branch head, but looks like it affects v0.1.0rc2 too
• Platform: Windows 10
• Subsystem:

The get_data method isn't working because it uses malformed date parameters. This happens within _call_api when _full_time==True because it appends a time stamp here and here onto the ISO-formatted datetime that already includes a timestamp.

For example, datetime.datetime.fromisoformat("2000-01-01").isoformat() returns '2000-01-01T00:00:00', so manually appending a timestamp results in an invalid datetime '2000-01-01T00:00:00T00:00:00' and causes the server to return a 400 error.

Just having get_data call _call_api with _full_time=False fixes the issue, but maybe that option can be removed entirely if there's no need for datetimes without a timestamp. This has been a really helpful package, so I'm happy to make a PR for this is you want.

Whether API

Include an API interface to NOAA's weather services.

Expand documentation

The sphinx documentation needs expansion. Needs to include allowed values, etc. in documentation.rst, and examples of how to use the code. A minimum of one simple example in index.rst and potentially a few more intermediate to advanced uses in examples.rst.

Import broken on main branch

Hi @exTerEX, this is a cool project, but it looks like there's some leftover code in the main branch that breaks imports if you install from source, and might be exposing an API key.

Running import noaa after installing with python -m pip install git+https://github.com/exTerEX/noaa.git#egg=noaa throws:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "C:\Users\Aaron\miniconda3\envs\geostats\lib\site-packages\noaa\__init__.py", line 1, in <module>
    import noaa
  File "C:\Users\Aaron\miniconda3\envs\geostats\lib\site-packages\noaa\climate.py", line 624, in <module>
    noaaobj = NOAA("xxxxxxxxxxxx")
NameError: name 'NOAA' is not defined

I redacted the actual key in the exception above.

Bug in get_data command

There is a known bug in the climate.NOAA function that lead to an error where urllib sends back a HTTP Error 400. Investigating the cause for this error.

Date-time ISO input

Include the other supported format for input in get_data, and add breaks to other functions to force correct behavior.