exyte / macaw Goto Github PK

We should make sure that we are using the same code style through whole project

let c = Circle(...) let animation = Animation(c, c.rProperty, 0, 100, 10s) let view = MacawView(c, animation) view.addAnimation(anotherAnimation)

Path will be tracked in a separate issue.

For example, Font and Fill don't have default values.

• Provide API for all kind of events (tap, swipe, pinch, zoom, etc)
• Technical details about implementation

If some classes removed from Kaway sources (like Parent) they should be removed from the Macaw sources during generation.

Currently only relative transformation supported.

Problems:

• Current Animation API requires user to say same things twice which makes it more error prone:

// need to say 'opacity' twice, need to say 'node' twice
OpacityAnimation(animatedNode: node, observableValue: node.opacityVar, ...)
// it allows user to make errors
OpacityAnimation(animatedNode: node1, observableValue: node2.opacityVar, ...)

• Animation needs registration through MacawView.addAnimation which makes API imperative VS declarative.

Proposal:

For every animatable property use AnimatableVariable, which has reference to Node, understand property type and has 'animate' method:

public class AnimatableVariable<T: Interpolable> : Variable<T> {
    public func animate(from: T, to: T, during: Double, ...) -> Animation
}

This method automatically register animation in global registry which then delegates to appropriate MacawView.

// current
let animation = OpacityAnimation(animatedNode: ballGroup, observableValue: ballGroup.opacityVar, startValue: 0.1, finalValue: 1.0, animationDuration: 3.0)
view.addAnimation(animation)
...
animation.stop()

// proposed
let animation = ballGroup.opacityVar.animate(from: 0.1, to: 1.0, during: 3.0)
...
animation.stop()

For example,
class Group: Node, Parent { }

See DropShadow class, the API is similar to CALayer.shadow... properties.

I've added model to the repo. The following code can be useful to draw radial gradient in Macaw:

let context = UIGraphicsGetCurrentContext()
let minSize = min(bounds.size.width, bounds.size.height)
let options: CGGradientDrawingOptions = [.DrawsAfterEndLocation]

// get from stops
let colors: CFArray = [UIColor.redColor().CGColor, UIColor.blueColor().CGColor]
let locations : [CGFloat] = [0.0, 1.0]
let gradient = CGGradientCreateWithColors(CGColorSpaceCreateDeviceRGB(), colors, locations)

// radial gradient parameters
let cx = 0.5  * minSize
let cy = 0.5  * minSize
let fx = 0.25 * minSize
let fy = 0.25 * minSize
let r  = 0.5  * minSize

CGContextDrawRadialGradient(context, gradient, CGPoint(x: fx, y: fy), 0, CGPoint(x: cx, y: cy), r, options)

See GaussianBlur and Node.effect. Useful links:

https://dzone.com/articles/applying-gaussian-blur-to-uiviews-with-swift-proto
https://www.raywenderlich.com/84043/ios-8-visual-effects-tutorial

scene:

• Rename Group.contentsVar to Group.contents
• Node.pos needs a better name
• TBD: Remove Drawable.bounds from the model
• Make Text.font optional
• Image.xAlign/yAlign/aspectRatio properties are too complicated and clumsy

draw:

• Remove AspectRatio
• Move static properties/methods of Color to Fill
• Remove unnecessary FontStyle and FontWeight
• Rethink Font.bold/italic/underline/strike properties. Need a better solution for Macaw.
• Gradient.userSpace needs a better name

geometry:

• Make sure we use consistent system for every angle
• Add Sector class
• Transform.invert should return nil when doesn't exist
• Move -> MoveTo, PLine -> LineTo
• Rethink Path API: do we really need excess model?

Currently: NSObject, expect: Bool.

This makes examples too difficult, so need to be done before release.

Currently Kaway doesn't support non-nullable types which means that all fields should be nullable by default. It's important because currently Group has non-nullable clip field which means it can't be used without clipping.

All coordinates inside layer are always positive. With anchor point (0, 0). In case of rotation transform it leads to incorrect layer position

Node.clip: Locus

Otherwise they are not accessible from another project.

• Generation
• Implementation

In Kaway every type has default value. Please use this value (or field default) in constructor. Currently objects with 5+ fields really hard to initialize.

For example, check out Quadratic

Check rotation case.

We should you Swift 3.0 policy for this.

That's what we need:

• draw
• geom2d
• input
• scene

What we DO NOT need:

• layout
• styles
• widgets

For example, Node.place changes ignored.

• Read me
• MacawView
• scene
• geometry
• draw
• effects
• animation
• events
• SVG

• MacawView
• scene: Shape/Text/Image/Group
• geometry
• draw
• effects
• animation
• events
• SVG

• nested svg tags parsing
• viewbox parsing
• gradients
• clipping
• defs
• text tspan
• opacity