Comments (21)
@svdoever Closed by #36 or it's something else?
from gatsby-starter.
@fabien0102 no is something else... tried to solve it, but can't find it. Is resizing the splitter working for you? Tried also to disable right side and getting it to botom using:
setOptions({
name: 'My website',
downPanelInRight: false
});
but did not help.
from gatsby-starter.
Ok, I got the bug at home, very strange! I'm trying to debug fix this in the morning 😉
from gatsby-starter.
So, apparently, it's a problem with ReactDOM.findDOMNode() in SplitPane… Very very strange 😕
https://github.com/tomkp/react-split-pane/blob/master/src/SplitPane.js#L100
https://reactjs.org/docs/react-dom.html#finddomnode
from gatsby-starter.
I tried to debug it myself as well, but could not solve it. Tried to update to latest version of react-split-pane, but both npm and yarn messed up the whole installation...
from gatsby-starter.
I have updated storybook and storybook-addons too, nothing happens ^^ I have tried react-split-pane alone in the last CRA (so with react 16) it works! Very very weird…
from gatsby-starter.
What is CRA?
from gatsby-starter.
Create React App -> https://github.com/facebookincubator/create-react-app
(official boileplate for react ;) )
from gatsby-starter.
Haha, all those acronyms... - use it all the time:-)
Your Gatsby template is the only project where I can reproduce this issue, works in all other situations:-(
from gatsby-starter.
I tried to remove everything (typescript, webpack.config, addons, stories) So just a basic example with a helloword story in javascript, always the same issue ^^
I'm trying to remove yarn.lock and node_module, after that, I don't have more idea!
from gatsby-starter.
😢 After a total reinstall of my node_modules without any yarn.lock
, same result… Very very strange…
from gatsby-starter.
Always the same issue after a getstorybook
! My god!
from gatsby-starter.
I got something!
Reproduction steps:
- new create-react-app
getstorybook
-> here everything worksyarn add gatsby
yarn storybook
-> BIM! no more panel dragging
So something happens between storybook and gatsby dependencies… But what!? ^^
from gatsby-starter.
So, that seams to be a yarn issue, it's working perfectly with npm i
on create-react-app. But obviously, I got manyyyyyyy other errors with storybook (with npm on this starter)
from gatsby-starter.
Ok now all is working, it was just double types declaration.
Dirty fix:
$ rimraf node_modules/\@types/react-test-renderer/node_modules
$ rimraf node_modules/\@types/react-dom/node_modules
@svdoever Do you an idea to fix this kind of issue? Or I just add a basic post-install
script to have a dirty fix…
from gatsby-starter.
In the tsconfig in the "paths" node it should be possible to specify which type definition files should have precendence in case of double type declarations, i.e.
{
"compilerOptions": {
"baseUrl": ".",
"outDir": "./dist/",
"sourceMap": true,
"noImplicitAny": true,
"allowSyntheticDefaultImports": true,
"module": "commonjs",
"target": "esnext",
"jsx": "react",
"lib": ["dom", "esnext"],
"types": [
"webpack-env",
"node"
],
"typeRoots": [
"./types",
"node_modules/@types",
"node_modules"
],
"paths": {
"react": ["./node_modules/@types/react"],
"*": ["./types/*", "*"]
}
},
"include": [
"./src/**/*"
]
}
maybe it is possible to solve this issue tht way?
from gatsby-starter.
Finally, I had just updgrade local types version for react, so no more double dependencies ;) But thanks for you tips, I keep this in mind for the next time it happens ^^
from gatsby-starter.
@fabien0102 when I install a fresh version of the GitHub repo I still get the splitter error... what should I do to solve the issue? Could you include the solution in the "fresh install"?
from gatsby-starter.
I’ve never merged my PR, I will try to do this today ;) But try with npm instead yarn, it’s a dependencies conflict issue ;)
from gatsby-starter.
@svdoever Normally it's ok with #38
Can you do a fresh install with npm and confirm that all are working for you? (I will close this issue after your confirmation 😉 )
from gatsby-starter.
Did gatsby new gatsby-starter-prestine2 https://github.com/fabien0102/gatsby-starter, same issue.
Then rimraf node_modules and npm install: issue fixed.
Then rimraf node_modules and yarn: problem is back.
Does gatsby new use yarn for install?
from gatsby-starter.
Related Issues (20)
- Cannot read tags group. HOT 4
- Create branch for Gatsby v2 HOT 12
- There are conflicting field types in your data. GraphQL schema will omit those fields. HOT 1
- Tags-Page.tsx template and blog.tsx page - corner case HOT 1
- Next branch error eslint-config-react-app missing HOT 3
- error GraphQL Error Unknown field `responsiveResolution` on type `ImageSharp` HOT 2
- how to remove disqus comment section with facebook comments
- what goes in siteMetaData googleVerification HOT 2
- Move `next` to `master`, move current `master` to `v1` HOT 2
- Repo description still says V1 instead of V2 HOT 1
- gatsby-browser and gatsby-ssr need to be Javascript HOT 1
- Allot of vulnerabilities in this repo HOT 2
- Styles from styled components not loading in production, SSR issue?
- Not work with node v11.11.0 && npm v6.7.0 && gatsby v2.4.10 HOT 1
- npm ERR! notarget No matching version found for gatsby@next HOT 3
- License? HOT 1
- Create a new site fails HOT 2
- [Suggestion] replace storybook-readme with Docs Addon HOT 1
- [Idea][Feature Request] Netlify CMS?
- Creating or overriding semantic-ui themes HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gatsby-starter.