fabrix-app / spool-cart Goto Github PK
View Code? Open in Web Editor NEWSpool - eCommerce for Fabrix
License: MIT License
Spool - eCommerce for Fabrix
License: MIT License
spool-cart/test/integration/2-controllers/admin/ProductController.test.js
Lines 678 to 687 in 76cccd6
Extension of #57
Endpoint | Response | Expected |
---|---|---|
Remove Image | Whole product object | removed image |
Add image | does not exist | new image objects |
Pricing Override not adjusting Pending Transaction
Variant Option not updated when passed as update.
Should cancel at cancellation date. Was cancelled 30 minutes after deactivating.
We still need an endpoint to just add one image (right now, I have to make an update call with all of the images)
When pushing images with the same src
, they can sometimes appear as duplicates and be injected twice. this causes an issue with updating positions when UPDATE calls need to be made.
Images are not being returned after being through the getVariant or getVariantImages endpoint after updating a variant through updateVariant
???
Get all collection images does not return image position
s or src
s, so images appear unsorted (this also could lead to issues down the line, both keys should be returned on add).
On Product Variant Property Pricing Changes and Product Property Changes, the variants should all be updated.
When removing an association (DELETE /product/:product/association/:association
) it should also return the updated array of associations on the product (currently returns the product instance)
When updating a variant, no images key is returned.
When GETing a product, the returned images array on that variant is an empty array.
spool-cart/lib/config/routes.ts
Lines 11612 to 11640 in 7d4e2f2
spool-cart/lib/config/routes.ts
Lines 3741 to 3765 in 7320685
Calling this endpoint returns a 404.
spool-cart/lib/config/routes.ts
Lines 3504 to 3524 in 7320685
also, it is not returning the updated object
Getting a product after adding a property to a variant doesn't get the new options array.
Repro:
spool-cart/test/integration/2-controllers/admin/ProductController.test.js
Lines 613 to 625 in 76cccd6
This test does not work in practice (not making association, returns empty array).
PUT /api/v1/customer/<id>/customers
DELETE /api/v1/collection/<id>/collection/<id>
DELETE http://localhost:4200/api/v1/product/<id>/variant/<variant>/images/<image>
PUT http://localhost:4200/api/v1/vendor/<id>/products
POST http://localhost:4200/api/v1/vendors
When uploading products through the admin panel - their calculated pricing is not getting updated to the newest pricing fix, it stays the old pricing.
This affects the front-end as it shows the calculated price to be displayed - as well as this part gets carried over to the cart checkout for the calculated price vs the compare_at_price and price columns.
Should use vendor objects
for future deprecation: this could/should be a DELETE request
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.