fabtotum / fablin Goto Github PK

From time to time the probing procedure reports a failed sample, even though the probe actually did stopped on an obstacle. The problem affect run_fast_z_probe, where probing is verified by:

if (READ(Z_MIN_PIN) != Z_MIN_ENDSTOP_INVERTING) {
  return true;
} else {
  return false;
}

It's possible that Z_MIN be unstable because of conversion from an analogue value which may still be too near the threshold when Z_MIN triggers. To fix this it should be necessary to run the verification multiple time.

In the file "FABlin/Marlin/Marlin_main.cpp", in the function "I2C_read()" there is a timeout with millis() after the Wire.requestFrom(). However, there is nothing to wait for.
Explanation: Common-mistakes#1

Since the return value of Wire.endTransmission() is not tested, the test for Wire.requestFrom() could perhaps be omitted as well:

  Wire.requestFrom(SERIAL_ID_ADDR, 1);    // request 1 bytes from slave device SERIAL_ID_ADDR
  return( (char) Wire.read());      // return a byte as character
}

When the Wire.requestFrom() needs a check for a valid I2C transaction, it could be like this:

  Wire.requestFrom(SERIAL_ID_ADDR, 1);    // request 1 bytes from slave device SERIAL_ID_ADDR
  if(Wire.available() != 1)       // request for 1 bytes failed ?
  {
    return('?');      // return a byte as character
  }
  else
  {
    return( (char) Wire.read());      // return a byte as character
  }
}

In the latest version 1.0.0095, external z-probe (continuity probe) does not work properly.
When enabled with "M746 S1" and started with G38. The z-axis starts moving up a few centimeters and stops without touching the external probe.
Version 1.0.0094 works without any problems.

It not shown in the list of codes but it within the effective code.

The latest version of the FABlin firmware (1.0.0098.1) for classic FAB-UI is unavailable via update or in the drop-down menu on the recovery page. (/recovery/flash.php).
The latest version available is 1.0.0098.

Symptoms:
Zmin endstop hit message is displayed even if M119 reports all Endstops as Open.

conditions:
-Reset the controller
-V 1.00.8 installed
-enter G28

Workaround:
-enter G27
-enter G28 (will slightly crash at Z_MAX