fac-11 / thelibrary Goto Github PK

You return your errors here:

• https://github.com/FAC-11/theLibrary/blob/master/src/handlers.js#L42
• https://github.com/FAC-11/theLibrary/blob/master/src/handlers.js#L51

instead of serving something meaningful to the user

Create a router which is server handlers according to endpoints.

Would be nice to submit a resource to the site

Create html doc.

Mobile first!

Doc should have grabable id's for js

Currently the DOM function is very large! Some of the code can be refactored into separate functions eg setClassAttributes, and called inside for ease of reading.

Set up a heroku site with a database

👍

Add a like button to articles which updates the database and sends back the current state of database for the page you are on

Project dependencies
env2
pg

Dev dependencies
tape
tap-spec
nodemon
istanbul
shot
eslint
travis

Add in scripts
tests: 'tape tests/*.test.js | tap-spec'
start: 'node ./src/server.js'
devstart: 'nodemon ./src/server.js'

This will allow us to make sure each individual only upvotes the one time amongst other things - possible integration with Gitter being one of them.

create build_script.js
create build_script.sql
create db_connection.js

Another stretch goal would be to add all the existing books in there in a table with possibility to request renting them, plus seeing which ones exist but are currently rented and stuff :-)

Problem with our event listener in 'dom.js' upvoting twice?!

If I click on a particular topic (e.g. callbacks), it would be nice to be able to go back to the list of all the resources available.

Right now, I can only choose to go to another topic from the list.

Folder database

• db_connection.js
• db_build.js
• db_build.sql

Folder public

• style.css
• index.html
• dom.js
• request.js
• Folder assets > favicon.ico

Folder tests

• Folder tests_ database (duplicate of database folder)
• database.test.js
• src.test.js
• public.test.js

Folder src

• server.js
• router.js
• handlers.js
• get_topic.js
• get_trending.js

In ROOT

• .gitignore (config.env, node_modules, ds_store)
• travis.yml
• config.env
• Procfile

following instructions from this morning

This may not have been explicitly stated to you guys, but it's really important that you have instructions in your readme that explain how to run your project locally.

In the case where you have a database in your project, you want to instruct people on:

• creating their database locally
• what environment variables they need to set
• what scripts they should run

etc.

Instead of these lines, you could just require in db_build_test.js, which does the same thing 👍

As currently we can only see four topics at a time without having to scroll.

Create file with getTopic function which takes a string and a callback.

Function will have to create a sql query with the string, then call dbConnection with the query string and pass the response to the callback

When user clicks on a topic on the site, an event listener will call the xhr function and pass in the dropdown value string.

They are currently appearing when you upvote (same as with the trending header on home page).

Instead we want to get rid of it completely as we have the topic title in the search/dropdown box.

Check how easy it is to query all topic names for each resource to be used in DOM.

(me and Aisha discussed this)

Because .query is async, maybe each test should be inside the callback e.g.

dbConnection.query(sql, (err, res) => {
  if (err) return console.log(err);
  tape('SQL query case check', (t) => {
    getTopic('css', (err, res) => {
      const actual = res[0].topic;
      const expected = 'CSS';
      t.equals(actual, expected, 'getTopic object output topic should be "CSS" as the SQL query string is case insensitive');
      t.end();
    });
});
});

https://github.com/FAC-11/theLibrary/blob/master/tests/database.test.js#L8

oops!

THanks :)

Figure out how our data is going to look - according to schema.

Do test coverage and add the badge to the readme <3

development%20methodologies > Development Methodologies please.

in request.js create an xhr request function that take a string value and a callback as arguments.

The function will feed the string into the url and pass the response text to the callback.

mobile first.

Add normalize.css

Except the dropdown which is a great size!

When scaling down, the upvote button progressively moves upwards out of centre.

make a mock database for testing purposes

With the removal of topic titles, we no longer have a way of signifying the front page is the trending section.

I've no suggestions at the moment as the title removal looks great, but worth thinking about how to incorporate it into the design :)

Dom function will take in an object and append each resource as a button.
It will clear the current content.
It will replace the title eg Trending will become css

is empty :(

They're cool :)
if you click on the badge that shows up on the travis site it will give you an image url you can add to your readme

same as get_topic.js but with a different query string

Draw out schema tables in readme

Given that you're building on this during biz dev time & intending for FAC to actually use this, could you move it into the foundersandcoders github organisation? 🙏

Just go to Settings -> ("Danger Zone" at the bottom) -> Transfer ownership -> Type in theLibrary & foundersandcoders

Should come up on page load but doesn't. Instead it appears on upvote click.

Don't let them do this!

Handlers will have 4 routes

• handle home
• handle public
• handle topic
• handle trending

Create a server using environment variables