fac-17 / denk Goto Github PK
View Code? Open in Web Editor NEWThe post-modern tarot lady
Home Page: https://denk-tarrot.herokuapp.com/
The post-modern tarot lady
Home Page: https://denk-tarrot.herokuapp.com/
Populate the database with actual cards and svgs
Readme is great and very profesh! It's nice to see that you put a lot of though into planning the functionality and design of your project.
Also it's awesome to see that you've kept some stretch goals in the backlog but the main functionality is done, tested and polished. Very impressive! ๐
Very important ๐
Remember to switch the person who's typing/the computer you're working on frequently. You could try doing something more strict like Pomodoro, which I recall worked quite well for our team. I suppose when planning out the project you could also work out what workflow is best for your team ๐
You can see the breakdown of contributors in the Insights tab.
It is AMAZING to see plenty of tests on all fronts!
Seems really good how you created flows and used a kanban board.
Would love to hear about this in your presentation.
Also presented really well in the readme
I found your code to be really readable, great function naming! ๐ฅฆ
You used a Kanban board and the wiki feature. Great job ๐ฅ
I think the file structure has been thought-through so it's easy to get around, which is awesome ๐
You test the fundamentals of your project. Good approach! ๐ฅ
Really helpful
So clean, so nice. The animations are amazing. SO impressed with what you've achieved :)
Love the use of SVGs, transparency, excellent fonts ๐ฅ
Your code is beautifully modular and clean in all places, if you remove the console logs here it will be perfect!
There is a big difference between the team member with the most commits and the least. I know Christine was away for some time so maybe this is why. Perhaps during refactoring you could balance this out.
Before starting your project you wireframed and used whimsical! Excellent job. I'm sure this made the project much easier when you were collaborating.
I see you wanted to commit an empty folder to GitHub with an empty .js file, I think the convention there is to use a file named .gitkeep
More on this here: https://stackoverflow.com/questions/7229885/what-are-the-differences-between-gitignore-and-gitkeep
Everything is in place and is neat and tidy ๐ ๐๏ธ
Very impressed!
for your great getRandomColor function:
const getRandomColor = () => {
return "rgb(" + [0, 0, 0].map(getRandomByte).join(",") + ")";
}
...Oh wait it's because you wrote it so cleanly :)
Well done. Honestly I expected there to be way more code to achieve what you did - you cut out all the fat and it made it so readable. Amazing job
Again, nothing major here, just best practise.
More here: https://ardalis.com/why-delete-old-git-branches
tape("Make awesome app", t => {
runDbBuild((err, res) => {
t.error(err, "No error");
t.equals(awesomeApp, actualApp)
t.end();
});
});
'Balls! What you're looking for isn't here'
'Internal rupture. Watch out!'
Nice!
Your app is just amazing!!!!
Well done ๐ฏ
Bravo!
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.