GithubHelp home page GithubHelp logo

denk's People

Contributors

crianonim avatar dependabot[bot] avatar georgiamshaw avatar gminova avatar victormasson21 avatar xirusux avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

georgiamshaw

denk's Issues

Great work! โœจ

Readme is great and very profesh! It's nice to see that you put a lot of though into planning the functionality and design of your project.
Also it's awesome to see that you've kept some stretch goals in the backlog but the main functionality is done, tested and polished. Very impressive! ๐Ÿ‘€

Remember to keep the commits even!

Very important ๐Ÿ˜
Remember to switch the person who's typing/the computer you're working on frequently. You could try doing something more strict like Pomodoro, which I recall worked quite well for our team. I suppose when planning out the project you could also work out what workflow is best for your team ๐Ÿ™ƒ
You can see the breakdown of contributors in the Insights tab.

Tests!

It is AMAZING to see plenty of tests on all fronts!

Great workflow

Seems really good how you created flows and used a kanban board.

Would love to hear about this in your presentation.

Also presented really well in the readme

Code readability

I found your code to be really readable, great function naming! ๐Ÿฅฆ

File structure

I think the file structure has been thought-through so it's easy to get around, which is awesome ๐ŸŒ

It's just great

So clean, so nice. The animations are amazing. SO impressed with what you've achieved :)

Balance of Commits

There is a big difference between the team member with the most commits and the least. I know Christine was away for some time so maybe this is why. Perhaps during refactoring you could balance this out.

GetRandomCompliment()

for your great getRandomColor function:

const getRandomColor = () => {
    return "rgb(" + [0, 0, 0].map(getRandomByte).join(",") + ")";
}

Where is all the extra code??

...Oh wait it's because you wrote it so cleanly :)

Well done. Honestly I expected there to be way more code to achieve what you did - you cut out all the fat and it made it so readable. Amazing job

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.