fac-17 / jackgreg Goto Github PK

Though the names of the files are very clear (and thus it's not so much of an issue) it could be nice to separate components into folders - the current set up looks pretty intimidating:

I managed to reach the limit for free request fairly easy, perhaps you can add a token to Netlify for longer user experience :)

Actually enjoyed reading through it and the logic comes across fairly easily - nicely done!

I really like the styling and the icons, but I think the buttons can be styled a bit more, like make them bigger so easier to see.

also well done for implementing they arrow key function, perhaps you could add some text to inform the user that you have that feature :)

Really like how the current page gets defined and all the relevant bits of information get passed from page to page in one place:

I like how you have used this to update various elements of the state... setScore, setTick, setPosition! Makes it all looks very clean and understandable!

I would suggest modularising your components into folders and subfolders

But I do love this winning feeling

getByText() will search for all elements that have a text node with textContent matching the given TextMatch

getByText(
  container: HTMLElement,
  text: TextMatch,
  options?: {
    selector?: string = '*',
    exact?: boolean = true,
    ignore?: string|boolean = 'script, style',
    normalizer?: NormalizerFn,
  }): HTMLElement

<a href="/about">About ℹ️</a>

import { render } from '@testing-library/react'

const { getByText } = render(<MyComponent />)
const aboutAnchorNode = getByText(/about/i)

Here is test on my machine:

It might just be my specific browser/screen size, but it took me a while to realise there were buttons off the bottom of the page :)