Comments (14)
@genlyken Sounds good. If no other issues I'll have it done by today.
from facebook-nodejs-business-sdk.
thanks for raising this issue. since request package is no longer active, we will consider to replace the request package with alternative solutions.
from facebook-nodejs-business-sdk.
@stcheng Thanks for the update! This is the only project not passing the vulnerability checks and our clients are concerned about this. We'd love to keep using this package. Is there a timeline on making this change?
from facebook-nodejs-business-sdk.
@genlyken, thank you for providing this feedback. Although we don't currently have a concrete timeline on this topic, I'll assess how extensive the change would be to replace the 'request' package with alternatives, and I'll escalate this issue to prioritize it. I'll keep this thread updated.
from facebook-nodejs-business-sdk.
@stcheng Thanks I appreciate your quick reply! I was digging further and it doesn't look like request is being used at all. I pulled it down locally and removed the dependency and all my tests passed. Perhaps we can just remove it from the package.json?
from facebook-nodejs-business-sdk.
@genlyken oh really! because if that is the case, would you mind create a pull request? I would be glad to help review it and facilitate the progress.
from facebook-nodejs-business-sdk.
@stcheng I thought I already did the CLA thing, but I'm getting 403 when I push. I was hoping maybe you can make the change as it should just be a one line delete in the package.json
from facebook-nodejs-business-sdk.
@genlyken this issue seems not that straightforward. the request package is required by request-promise which is used in http.js file(https://github.com/facebook/facebook-nodejs-business-sdk/blob/main/src/http.js#L12). Thus, some code changes are required to deprecate both request and request-promise. I'll do some further investigation here.
from facebook-nodejs-business-sdk.
@stcheng i submitted a PR (#257), but I haven't figured out the CLA yet. I'm using axios and I tested this code by creating a campaign, adset and ad and uploaded a video, but there's plenty of FB code that I'm not familiar with and haven't tested. I'd love if you can take a look!
from facebook-nodejs-business-sdk.
@genlyken saw the PR. thank you! let me know if you're able to complete CLA or not.
from facebook-nodejs-business-sdk.
@stcheng I think there's an issue with my CLA where i mixed up my github accounts. Paul from meta messaged me, but I think it takes a while to clean this up.
from facebook-nodejs-business-sdk.
@genlyken any luck getting the CLA? if not, do you want me to get it addressed on behalf of you?
from facebook-nodejs-business-sdk.
@stcheng I haven't had any change in status on the CLA. I'd appreciate any steps moving forward!
from facebook-nodejs-business-sdk.
closing in favor of a2d64d9
from facebook-nodejs-business-sdk.
Related Issues (20)
- Can we release v17.0.0? HOT 6
- Missing Advertiser Tracking Enabled Flag even though it is set though setAdvertiserTrackingEnabled HOT 2
- Feature Request: Audience Overlap
- Can't figure out how to create a playable ad using SDK
- Sending wrong params when creating campaign
- Server Side Api Parameter Error: Unexpected key "advertiser_tracking_enabled" HOT 8
- AdsPixel Id is not defined HOT 1
- 17.0.3 introduces error: "TypeError: Cannot read properties of undefined (reading 'map')" HOT 5
- Global debug mode flag does not work for EventRequests
- Not receiving specific errors when calling HOT 12
- Boost post to Saved audience
- Creating Product Sets and adding items HOT 1
- Campaign, ad set, ad example
- No permission to access this profile getGeneratePreview() error
- Issue importing 'FacebookRequestError' HOT 2
- Trying to run one of the basic SDK examples results in SDK crash HOT 1
- `AdVideo` fields are incorrect
- `getAds` never returns `video_id` field
- Is it possible to filter on Ad Creatives based on updated_at the way we do it in AdSets??
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from facebook-nodejs-business-sdk.