GithubHelp home page GithubHelp logo

Comments (12)

krishna-koushik avatar krishna-koushik commented on April 28, 2024 6

+1

from facebook-nodejs-business-sdk.

simonbrunel avatar simonbrunel commented on April 28, 2024 2

Same issue, fixed by downgrading to v17.0.2 so most probably introduced by this commit.

@stcheng Would you be able to have a look at it?

from facebook-nodejs-business-sdk.

sebrichards avatar sebrichards commented on April 28, 2024 2

Hey @stcheng thanks for the fix, but why wasn't this backported to v17 given it's still in the support period?

from facebook-nodejs-business-sdk.

stcheng avatar stcheng commented on April 28, 2024 1

working on a fix; will update soon.

from facebook-nodejs-business-sdk.

krishna-koushik avatar krishna-koushik commented on April 28, 2024 1

Sorry for the late reply. I am able to confirm that the fix worked on v18.0.2. Thank you :)

from facebook-nodejs-business-sdk.

stcheng avatar stcheng commented on April 28, 2024 1

@krishna-koushik no worries. thanks for confirming this.

from facebook-nodejs-business-sdk.

stcheng avatar stcheng commented on April 28, 2024

will take a look. if no short term feasible solutions, i would probably do a git revert on this specific commit. thanks for reporting this.

from facebook-nodejs-business-sdk.

ahmtakf avatar ahmtakf commented on April 28, 2024

You should debug "constructErrorResponse" method and see what fields axios response returns. You return undefined because you do not construct from the correct fields on version 18.0.1.

from facebook-nodejs-business-sdk.

aaronhayes avatar aaronhayes commented on April 28, 2024

@stcheng have you had a chance to debug this one yet?

from facebook-nodejs-business-sdk.

aaronhayes avatar aaronhayes commented on April 28, 2024

Thanks!

from facebook-nodejs-business-sdk.

stcheng avatar stcheng commented on April 28, 2024

anyone please help verify if this issue has been properly addressed and if that is the case i'll tag a new version thank you all

from facebook-nodejs-business-sdk.

stcheng avatar stcheng commented on April 28, 2024

closing this as addressed in v18.0.2.

from facebook-nodejs-business-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.