GithubHelp home page GithubHelp logo

Comments (6)

TheSavior avatar TheSavior commented on April 28, 2024 2

Thanks for flagging this. We've been aware of this policy and are working on the necessary steps

from hermes.

ikhvorost avatar ikhvorost commented on April 28, 2024 2

Hi @tmikov!

If you open hermes-engine.podspec you can find:

unless ENV['hermes-artifact-url']
    spec.prepare_command = <<-EOS
      # When true, debug build will be used.
      # See `build-apple-framework.sh` for details
      DEBUG=#{HermesHelper::BUILD_TYPE == :debug}

      # Build iOS framework
      ./utils/build-ios-framework.sh

      # Build Mac framework
      ./utils/build-mac-framework.sh
    EOS
  end

The scripts build Xcode frameworks both ios/tvos automatically for Cocoapods in destroot/Library/Frameworks/universal/hermes.xcframework when you add it as a dependency to your project and the same as React Native does.

So the scripts should put PrivacyInfo.xcprivacy file inside these frameworks while building, shouldn't?

from hermes.

cguino avatar cguino commented on April 28, 2024 1

It looks like Apple may be referring to this Hermes, not our JS engine: https://github.com/imgur/hermes

This repository is archived, last release Jul 2015

from hermes.

tmikov avatar tmikov commented on April 28, 2024 1

Please note that Hermes repository is just source code and doesn't provide binaries for iOS. Hermes obviously doesn't collect any data or do anything privacy related, it is just a library, but we can't include a privacy manifest in the source, it has to be paired with a binary, and we don't provide one.

This has to be addressed by React Native (I believe it will be soon) or anyone else who compiles and distributes a Hermes binary.

from hermes.

tmikov avatar tmikov commented on April 28, 2024

It looks like Apple may be referring to this Hermes, not our JS engine: https://github.com/imgur/hermes

from hermes.

RhyG avatar RhyG commented on April 28, 2024

Has there been any movement here? I can see @tmikov mentioned it potentially being another lib but not sure how to verify. Currently have some pretty nervous stakeholders at the moment is all.

If there's anything the community can do to support the change happy to help. Thanks!

from hermes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.