Why react should be declared as peerDependencies and prop-type as dependency ? about prop-types

[gaearon]

I think the main difference is the user tends to know which version of React they need, but might not care about prop-types. So letting the user choose with react seems more important. Since peer dependencies are generally a pain, it would be great to reduce the reliance on them, and this seems like a case where it could work.

But I agree the distinction is fuzzy.

[jedwards1211]

Well the other thing no one's mentioned here is if various components depend on incompatible versions of prop-types, it's not a problem, because each can independently use the version it needs, whereas everything has to be using the same version (i.e. actual runtime instance) of React.

[pgn-vole]

Thanks for the explanation @gaearon. Would you suggest that libraries should bundle prop-types or reference it (as they do with React) ?

[benwiley4000]

Thanks for the explanation; perhaps some version could make it to the README. I think the key thing to understand is that prop-types will still be bundled during the user app's compile step, not the library's; though unlike with react it's unnecessary that the user app explicitly depend on prop-types.

[gaurav5430]

with a monorepo setup, where a lot of packages from the monorepo are going to be used across consumers, we have figured that it makes sense to just add it as a peer dependency instead of a dependency. I mean, it could very well be a dependency sure, but it just makes sense to treat it as other dependencies