Comments (5)
How do we practically expect Java users to do that?
We would expect them to write C++, hence the "native" aspect. I have updated the wording to try and make that clearer.
Thanks for your work on this @neilramaswamy.
from rocksdb.
Seems like a good idea. What is your opinion on adding it to an existing page, or whether to add a new page in its own right? i.e. where do you think (as a user) it would best be found in the Wiki?
from rocksdb.
I think adding a "Logging" page under the RocksJava wiki would be best. The existing RocksJava Basics page is getting a bit long in my opinion, and this isn't really a basic feature -- the RocksDB logs certainly won't be useful for anyone with a "basic" use-case.
from rocksdb.
@neilramaswamy Thanks, I have added a page based on your example here - https://github.com/facebook/rocksdb/wiki/Logging-in-RocksJava
- I also adapted it to demonstrate a slf4j bridge.
- I tried to make the memory management responsibilities when using Logger clearer.
What do you think?
from rocksdb.
Just confused about one part:
but implementing your own native logger is also possible.
How do we practically expect Java users to do that? For our native logger changes, we have support over on the C++ side. If you're just suggesting that users can submit a PR to add another native logger, maybe that can be made more explicit. Currently, it sounds possible from RocksJava, but I don't think it is.
Otherwise, this is great!
from rocksdb.
Related Issues (20)
- How Are the Tiered Storage and Adaptive Compaction Projects Going? HOT 1
- rocksdb 8.9.1 unit test failed HOT 4
- Iterator seek not seeking to the right position HOT 1
- Feature Request: rate limit compaction but not flushes HOT 4
- JNI ColumnFamilyHandle#getDescriptor method leaks memory HOT 8
- Iterator is still valid after calling the `Reset` HOT 5
- Strange exported function names in official Maven build for Windows HOT 15
- db_bench support user defined timestamp HOT 6
- Potential bug in the cmake files.
- Cross-compilation issue with projects that use RocksDB built using Conan or Cmake on macOS with x86_64 CPU and targeted for arm64 CPUs HOT 4
- LRUCache issue
- Potential data race when deleting obsolete files
- Potential crash-consistency vulnerability when allow_mmap_writes is enabled HOT 4
- Question about compression type in rocksdbjava benchmark HOT 1
- Undefined symbols for architecture arm64 in MacOS
- Documentation is unclear about manual_wal_flush with WriteOptions::sync and without two_write_queues HOT 1
- Changes in noise in regression test results
- Missing documentation - How To Backup RocksDB page HOT 2
- delta snapshots computation HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rocksdb.