GithubHelp home page GithubHelp logo

Comments (5)

adamretter avatar adamretter commented on April 28, 2024 2

How do we practically expect Java users to do that?

We would expect them to write C++, hence the "native" aspect. I have updated the wording to try and make that clearer.

Thanks for your work on this @neilramaswamy.

from rocksdb.

adamretter avatar adamretter commented on April 28, 2024

Seems like a good idea. What is your opinion on adding it to an existing page, or whether to add a new page in its own right? i.e. where do you think (as a user) it would best be found in the Wiki?

from rocksdb.

neilramaswamy avatar neilramaswamy commented on April 28, 2024

I think adding a "Logging" page under the RocksJava wiki would be best. The existing RocksJava Basics page is getting a bit long in my opinion, and this isn't really a basic feature -- the RocksDB logs certainly won't be useful for anyone with a "basic" use-case.

from rocksdb.

adamretter avatar adamretter commented on April 28, 2024

@neilramaswamy Thanks, I have added a page based on your example here - https://github.com/facebook/rocksdb/wiki/Logging-in-RocksJava

  • I also adapted it to demonstrate a slf4j bridge.
  • I tried to make the memory management responsibilities when using Logger clearer.

What do you think?

from rocksdb.

neilramaswamy avatar neilramaswamy commented on April 28, 2024

Just confused about one part:

but implementing your own native logger is also possible.

How do we practically expect Java users to do that? For our native logger changes, we have support over on the C++ side. If you're just suggesting that users can submit a PR to add another native logger, maybe that can be made more explicit. Currently, it sounds possible from RocksJava, but I don't think it is.

Otherwise, this is great!

from rocksdb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.