Comments (2)
It's most likely because allow_write_stall
in FlushOptions
was added later (in 2018). The usage of default FlushOptions here existed before 2016.
I personally think it should be okay to proceed with the Flush(), waiting for stall conditions if users want. The next Open() will then stall for writes early. Maybe it can be configurable parameter passing in CancelAllBackgroundWork()
from rocksdb.
Sure i can do that.
Im just worried that this new parameter will be too confusing since it means "flush will wait for some stall conditions to clear if there is unpersisted data".
This new parameter will have no effect if theres no unpersisted data.
Also, this might conflict with the already existing parameter of CancelAllBackgroundWork()
since a user can pass wait = false
and allow_write_stall = false
which translates into "dont wait for bg work but wait for stall conditions to clear" (meaning it will wait for some bg work even though wait is false).
Last point is that we'd always want to flush unpersisted data as fast as possible right?
@hx235 what do you think?
from rocksdb.
Related Issues (20)
- RocksJava - Options cannot be instantiated directly HOT 1
- Opening LevelDB with corrupted MANIFEST-0* file HOT 6
- when to use checkpoint vs opening rocksdb in read only mode HOT 4
- Installation documentation for OSX is out of date HOT 3
- ArenaTest.UnmappedAllocation fails when "transparent hugepage" is enabled.
- API request: SeekForBase
- Master branch unable to find zstd HOT 1
- RocksDB crashing when doing simple get HOT 5
- unexplained sudden increase in memory usage HOT 14
- DirectIO WAL Write does not honor DBOptions.use_fsync HOT 2
- New LZ4 encoding HOT 1
- release 8.10.2 on maven central HOT 1
- tailing iterator ambiguity
- When run in two consecutive times DB::Open has quite different time cost HOT 2
- Is it possible to make the db.get operation after db.close without exception? HOT 3
- Feature Request: Graceful upgrade
- There is an error when I am compilling rocksDB version above 8.10.0 with zenFS 2.1.4 HOT 1
- Doc bug: CustomFilterPolicy example
- Feature request: check if prefix exists without seeking HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rocksdb.