Comments (3)
Pardon my lack of GitHub experience, but can we make a separate branch for v2.3 support? I'd be happy to accept patches to such a branch. We'd have to cherry pick the changes which apply to things outside of the v2.3/2.4 split.
If you're willing to help get that off the ground, we can approve it at this end.
My only concern that is that we'll be turning off all support for v2.3 in December 2015. That's only a few months away! :)
from threatexchange.
This was sort of a decision on my end. With 2.4 being so drastically different, and ( @jessek correct me if I'm wrong ) with previous versions being deprecated in a couple months, I decided to version-lock this release to 2.4. I use the term "version-lock" very loosely here as all I did was set ThreatExchange.VERSION to 'v2.4/' (https://github.com/facebook/ThreatExchange/blob/master/pytx/pytx/vocabulary.py#L8) and update the vocabulary and available fields appropriately.
If you wish to use previous versions while using the latest version of pytx, you can still use the Broker:
url = ThreatExchange.URL + 'v2.3/' + ThreatExchange.THREAT_INDICATORS
response = Broker.get(url, params={'text': 'foo'})
It doesn't give you some of the nice stuff that the classes do, but if you absolutely need to query previous versions it's at least available. If you really need the older version objects, you can use a previous release of pytx for those. The previous versions supported all < 2.4 versions of the Graph API.
from threatexchange.
As it's now December and we are getting ready to turn off support for v2.3, I am going to close this out.
from threatexchange.
Related Issues (20)
- [hma] submitting content gets stuck between "hashed" and "matched" HOT 2
- /matches/for-hash/ gives AttributeError: 'IndexMatchUntyped' object has no attribute 'distance' HOT 1
- [pytx] No match results if creating a local_file with only 1 hash in it HOT 1
- [hma] Size of hashkey has exceeded the maximum size limit of 2048 bytes HOT 3
- [hma] ValueError in indexer
- [vpdq] Add support for Windows in vpdq pypy package HOT 5
- [OMM] Set up basic Continuous Integration git workflows for OMM HOT 2
- [omm] Figure out design for background tasks HOT 5
- [hma] Test production deployment - Nice-to-haves and Need-to-haves HOT 5
- [omm][onboarding] Initial setup issues HOT 2
- psycopg2.errors.UndefinedTable: relation "signal_type_override" does not exist HOT 8
- [vpdq] pypi publish failing HOT 2
- [omm][hma] Move Open Media Match into the Hasher Matcher Actioner Directory HOT 1
- Refactor UI to allow for multiple pages
- Flask background task scheduler doesn't run if werkzeug is not the WSGI server
- [hma][py-tx] Unclean CI status for HMA and pytx HOT 4
- [vpdq] Explore other packaging and build options
- [hma] Add optional distance parameter in match API
- [pytx] Add support for StopNCII PhotoDNA
- [hma] Bad redirects on dev page HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from threatexchange.