GithubHelp home page GithubHelp logo

Comments (15)

forestgagnon avatar forestgagnon commented on June 15, 2024 6

@jonyeezs @Dotmagic I just opened a PR on seti-ui which resolved the issue for me: jesseweed/seti-ui#459

from atom-ide-ui.

camlafit avatar camlafit commented on June 15, 2024 5

Hello

I get also this error. I use adwait pro ui theme (https://github.com/forivall/adwaita-pro-ui/). Error is come with latest atom-ide update

from atom-ide-ui.

jonyeezs avatar jonyeezs commented on June 15, 2024 3

Have the same problem as well
Using Seti UI theme
and New Moon syntax theme

.atom\packages\atom-ide-ui\modules\nuclide-commons-ui\styles\TextEditorBanner.less:15:15

LessError: variable @font-family is undefined
  at C:\Users\jonathan.yee\.atom\packages\atom-ide-ui\modules\nuclide-commons-ui\styles\TextEditorBanner.less:15:15

I'm also using this package fonts

from atom-ide-ui.

hansonw avatar hansonw commented on June 15, 2024 2

Sorry, just published v0.8.1 to fix this!

from atom-ide-ui.

 avatar commented on June 15, 2024 1

@jonyeezs I'm using seti theme too. Switching to "Atom Dark" Theme resolved the issues for me.

from atom-ide-ui.

hansonw avatar hansonw commented on June 15, 2024

Thanks for the report. The @font-size variable seems to be something that's declared across all the default Atom themes and others like Material UI. I'm inclined to think that this is something xatom-ui should declare here:

https://github.com/willyelm/xatom-ui/blob/master/styles/ui-variables.less#L68

For comparison:

https://github.com/atom/one-dark-ui/blob/master/styles/ui-variables.less#L83
https://github.com/atom-material/atom-material-ui/blob/master/styles/ui-variables.less#L78

Although there's no official spec for what ui-variables should contain, this seems like a reasonably standard thing to have.

from atom-ide-ui.

cnurre avatar cnurre commented on June 15, 2024

Admittedly, after digging a bit deeper and trying a few more 3rd party themes after submitting this issue it does appear you're right. This is probably an issue with Xatom. Thanks for quick response.

from atom-ide-ui.

almostsultry avatar almostsultry commented on June 15, 2024

I get a slight variation on this:

LessError: variable @button-background-color-selected is undefined
at /Users/captbackfire/.atom/packages/atom-ide-ui/modules/nuclide-commons-ui/styles/Table.less:112:16

from atom-ide-ui.

damieng avatar damieng commented on June 15, 2024

@almostsultry This is a problem with the theme you are using.

from atom-ide-ui.

anthonybrown avatar anthonybrown commented on June 15, 2024

@forestgagnon , how? I'm using seti for the UI theme but I'm still getting the error

from atom-ide-ui.

parasyte avatar parasyte commented on June 15, 2024

I got this error with a different variable. But my syntax theme already defines the variable:

LessError: variable @syntax-background-color is undefined
  at /Users/parasyte/.atom/packages/atom-ide-ui/modules/nuclide-commons-ui/styles/LinePreview.less:6:23

The variable is defined here: https://github.com/parasyte/pretty-pastels-syntax/blob/master/styles/syntax-variables.less#L10

from atom-ide-ui.

parasyte avatar parasyte commented on June 15, 2024

Found that this is still related to the UI theme, since mine doesn't import syntax-variables, I get this error. The core themes atom-dark-ui and atom-light-ui are affected by this bug as well.

The core themes atom-one-dark-ui and atom-one-light-ui both import syntax-variables, and they both work fine with atom-ide-ui.

Adding @import "syntax-variables"; to the UI theme is a workaround. But note there are core themes missing this.

from atom-ide-ui.

parasyte avatar parasyte commented on June 15, 2024

Oh nice, there is a PR that fixes the issue I described -> #160 Just awaiting release.

from atom-ide-ui.

Arcanemagus avatar Arcanemagus commented on June 15, 2024

This should be fixed here by #160.

from atom-ide-ui.

Deuxis avatar Deuxis commented on June 15, 2024

Can confirm, I had the issue even though I use Atom Dark (for both window and syntax), updating atom-ide-ui to v0.8.1 fixed it. Nice work!

from atom-ide-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.