A Problem About .got Table Updates about bolt

[maksfb]

Sorry, missed that earlier. Yes, you are right that GOT will not get updated in this case. What application were you trying to optimize?

[CcWeapon]

We try to replace getBinaryFunctionAtAddress() with getBinaryFunctionContainingAddress() in func getNewFunctionAddress().

uint64_t RewriteInstance::getNewFunctionAddress(uint64_t OldAddress) {
  const BinaryFunction *Function = BC->getBinaryFunctionContainingAddress(OldAddress);
  if (!Function)
    return 0;

  assert(!Function->isFragment() && "cannot get new address for a fragment");

  auto MultientryOffset = BC->getMultientryOffsets().find(OldAddress);
  if (MultientryOffset == BC->getMultientryOffsets().end()) {
    return Function->getOutputAddress();
  } else {
    return Function->getOutputAddress() + MultientryOffset->second;
  }
}

[maksfb]

Sounds like you fixed it in your fork?

[CcWeapon]

Yes, func getBinaryFunctionContainingAddress() is used to solve the problem.