GithubHelp home page GithubHelp logo

Comments (4)

ssorallen avatar ssorallen commented on May 23, 2024 1

@balaji, for now we are removing the icon-file-code usage inside Nuclide so this package will work. We can look at a more robust API for file tree customization later.

from nuclide.

balaji avatar balaji commented on May 23, 2024

Doing the first item solves the problem w.r.t file-icons package because icon-file-text class is already present (through atom-helpers package).

Are you suggesting that in future there will be customizations on the tree view based on this class or that the class itself will go away?

from nuclide.

balaji avatar balaji commented on May 23, 2024

My bad. Sorry. I didn't check the code close enough. Looks like we add icon-file-code for desired file extensions.

  ...
  } else if (CODE_EXTENSIONS.hasOwnProperty(ext)) {
    typeClass = 'icon-file-code';
  } else {
    typeClass = 'icon-file-text';
  }

from nuclide.

ssorallen avatar ssorallen commented on May 23, 2024

This is fixed with commit 4041973. Nuclide's file tree does less customization to allow the file-icons package to work.

from nuclide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.