Comments (4)
@balaji, for now we are removing the icon-file-code
usage inside Nuclide so this package will work. We can look at a more robust API for file tree customization later.
from nuclide.
Doing the first item solves the problem w.r.t file-icons package because icon-file-text
class is already present (through atom-helpers
package).
Are you suggesting that in future there will be customizations on the tree view based on this class or that the class itself will go away?
from nuclide.
My bad. Sorry. I didn't check the code close enough. Looks like we add icon-file-code
for desired file extensions.
...
} else if (CODE_EXTENSIONS.hasOwnProperty(ext)) {
typeClass = 'icon-file-code';
} else {
typeClass = 'icon-file-text';
}
from nuclide.
This is fixed with commit 4041973. Nuclide's file tree does less customization to allow the file-icons package to work.
from nuclide.
Related Issues (20)
- Fail to load nuclide package. Cannot find module 'fb-appsession-observer' HOT 5
- apm install [email protected] not working
- nuclide-js-imports-server/nuclide-js-imports-client doesn't work HOT 1
- Nuclide 0.360.0 update doesn't work HOT 5
- I have try to install nuclide package. after that i got this issue HOT 1
- Is Nuclide-definition-preview supposed to be working with remote Nuclide server?
- where do I disable this git coloring ?
- Output from Eslint missing HOT 7
- [Ubuntu] Flow was not found when attempting to start it in
- CMake C project and compile_commands.json
- Uncaught TypeError: Cannot read property 'children' of undefined
- nuclide-buck unable to find @accent-text-color HOT 6
- Failed to load the nuclide-buck package HOT 2
- Spotty Remote Connection
- Uncaught TypeError: Cannot read property 'bind' of undefined
- Uncaught Error: Connection Closed
- `atom .` doesn't work w/ v366 terminal
- No Typechecking in Fresh Install of Nuclide + Hack HOT 2
- [email protected] – Cannot find module se.node' HOT 2
- Uncaught RpcTimeoutError: Timeout after 60000 for id: 3, Calling function FileSystemService/findN...
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nuclide.