Comments (3)
jgkamat
commented on May 4, 2024
Hmm, if we don't inject JLOG macros without -l (during codegen), wouldn't we need to regenerate caches every time we want to see debug logging? It saves a lot of time for debugging to have these in always. I'm wondering if we can mitigate the cost of these statements somehow without removing them
from object-introspection.
tyroguru
commented on May 4, 2024
Yes, we'd have to regenerate the cache. We need to do the analysis to see exactly what the effects of removing these are but in general I'm very much against having code permanently in there for debugging purposes especially when in the hot path as JIT code instructions are.
from object-introspection.
tyroguru
commented on May 4, 2024
This was fixed by turning jit logging into a feature flag (#183)
from object-introspection.
Related Issues (20)
- folly::small_vector needs updating for treebuilder v2 HOT 1
- folly::fbstring needs updating for treebuilder v2
- Linking error when trying to compile HOT 3
- CI should build with clang-15
- what's required to support shared libs? HOT 1
- issues with CMake dependency handling HOT 2
- is gcc supported for client applications? HOT 2
- Incorrect testing advice in PR template
- Review replay instruction code
- result::Element contains potentially redundant pointer information
- OIL uses a single shared pointer set even though it can be called concurrently
- The pointer tracking mechanism hangs threads with >125k pointers
- Jit logging missing from new toml definitions HOT 1
- Logging cleanup
- folly::IOBuf is missing tests
- tbv2: pointer code generation is broken
- tbv2: codegen fails on top level incomplete objects
- tbv2: delegate is required for complex processors when write should work
- `folly::sorted_vector_map` ignores the underlying container and pair HOT 1
- Cached data for `oi::SizedResult` is stored in the short lived iterator
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from object-introspection.