fadikurdi / hyf-javascript1- Goto Github PK

Hi Fadi, here is my feedback on your homework.

• The structure of your repo is not completely according to what was asked.

  • The name of the repo should be hyf-javascript1. Mind the all lowercase name and no hyphen at the end.
  • It should contain a folder named week2 where you were to place your file Hello.js.
  • The root directory of your repo (hyf-javascript1) should contain a .gitignore file and an .eslintrc.json file as we did at the end of the lecture. The .gitignore file is created when you click the appropriate check box when creating the repo on GitHub. To create the .eslintrc.json file follow the instructions in the VSCode Tips.

• When I run your code I get an immediate run time error at line 50. This is because you re-declared the variables x. Same thing for variable y. Am I testing the same code that you were running? If yes, then you must have encountered the same problem and have fixed it. If no, then please make sure next time that I get the same code that you tested.

• If you want to have all exercises in one file then make sure that it runs as one file. I don't think it is reasonable to expect the reviewer to extract the individual exercises in separate files in order to test them. Your code should work as-is.

If you can make the necessary changes I will continue the review.

great job Fadi, keep working hard.