fanf2 / regpg Goto Github PK

It looks like there is an issue with quoting.

$ regpg recrypt -r
grep: ./secrets/general/Visual: No such file or directory
grep: COBOL: No such file or directory
grep: Linux-UNIX: No such file or directory
grep: for: No such file or directory
grep: PeopleSoft.xml.asc: No such file or directory
grep: ./secrets/general/COBOL: No such file or directory
grep: Server: No such file or directory
grep: Runtime: No such file or directory
grep: for: No such file or directory
grep: PeopleSoft.xml.asc: No such file or directory

I was expecting these files to be recrypted, and but they are not:

$ ls -l secrets/general/[CV]*
-rw-rw-r--. 1 psh35 psh35 13695 Jan  8 12:17 'secrets/general/COBOL Server Runtime for PeopleSoft.xml.asc'
-rw-rw-r--. 1 psh35 psh35 11229 Jan  5 17:15 'secrets/general/Visual COBOL Linux-UNIX for PeopleSoft.xml.asc'

The files have not been recrypted. It looks like an issue with quoting.

Hello Tony,

Would you please include instructions to build from source?

• perl version requirements (if any)
• required Perl modules (e.g. for Debian and Ubuntu distributions, required packages are make and libtext-markdown-perl, cpan instructions etc.)
• Type make to build everything, make regpg for just the program, make test to run the testsuite, make install to install into ${HOME}/bin etc.

Hi,

I ran regpg init ansible on an existing ansible setup, and rather than updating action_plugins and filter_plugins, it over-wrote them:

diff --git a/ansible.cfg b/ansible.cfg
index a408c12..b7507b0 100644
--- a/ansible.cfg
+++ b/ansible.cfg
@@ -118,12 +118,12 @@ ansible_managed = Ansible managed: {file} modified on %Y-%
 
 
 # set plugin path directories here, separate with colons
-action_plugins     = /etc/ansible/plugins/action_plugins
+action_plugins = plugins/action
 callback_plugins   = /etc/ansible/plugins/callback
 connection_plugins = /etc/ansible/plugins/connection_plugins
 lookup_plugins     = /etc/ansible/plugins/lookup_plugins
 vars_plugins       = /etc/ansible/plugins/vars_plugins
-filter_plugins     = /etc/ansible/plugins/filter_plugins
+filter_plugins = plugins/filter
 
 # by default callbacks are not loaded for /bin/ansible, enable this if you
 # want, for example, a notification or logging callback to also apply to

We should have ended up with e.g. action_plugins = /etc/ansible/plugins/action_plugins:plugins/action

Regards,
Matthew

Tests fail when locale is not set to C or an English one

Steps to reproduce:
$ make && make test

Expected:

All perl tests succeed.

Observed:

Some tests fail because gpg's output do not match expected patterns (e.g. ('?^:imported)

Workaround:
$ LANG=C make test

Hi,

One might reasonably want to run regpg init git without having a secret key available (e.g. to arrange such that you can use git diff on the keyring and have it show you changes usefully). This doesn't currently work:

$ regpg init git
pipe from gpg --list-secret-keys --with-colons git
gpg: error reading key: secret key not available
pipe from gpg failed

Thanks,
Matthew

Building fails when processing Markdown source files

Steps to reproduce

Platform is Debian 8, with packages make and libtext-markdown-perl.

~/regpg-regpg-0.99$ LANG=C make

Expected

No errors; files generated in doc/

Observed

Errors out as follow:

util/markdown.pl doc/contributing.md doc/contributing.html
Undefined subroutine &Text::Markdown::Markdown called at util/markdown.pl line 29, <$hin> chunk 1.
Makefile:75: recipe for target 'doc/contributing.html' failed
make: *** [doc/contributing.html] Error 255