fanzhangg / chord-master

A web application for building chord progression

Hi, I am Fan Zhang 👋

Selected projects:

• Chord Master: Build your chord progression
• Entre: A social platform for entrepreneurs
• Mask Detection: Detect whether people wear a mask in video
• L-system Simulator: Create recursive art using L-system grammar
• Database on Japan War Crime: A database for research on Japanese war crimes during WWII
• Rush Rush Rush: A unity 3D-platformer game
• My website

chord-master's Issues

Add chord progression/ piano roll

Set a C chord if a user selects a chord type

Fix the notation of chord

Not able to pitch up keyboard to reach higher notes. Maybe add a button to go up and down octaves

Make every id variable as an integer

Changing the chord type and adding new chord type will add it with the new type applied before the new chord is displayed.

The keys without binding triggers keys

The label will not be changed if you select a certain inversion

The octaves are too low in a small screen

The radio inputs does not highlight the selected input

The checked property will change based on the user's click, but the highlight on the button does not change

Have a better keyboard mapping

Have black and white keys on separate rows, use z, x to change octave

Add button needs to be disabled when single note is selected or there are no notes selected.

Keys doesn’t highlight in mobile

Disable editing the chord when playing the progression

Keyboard Start from C4 on a mobile device

First chord doesn’t play in mobile device

Use data-note instead of id to identify each key

Use character of sharp and flat instead of supscripts

Sometimes it takes 2 clicks to play the progression

There is a gap between 2 keys in the piano

The piano does not highlight keys based on the chord type

Right now the piano highlights the keys of the major chord in any case. This issue is tricky to solve, because I add an event listener to every key when resizing the keyboard, so the key will only take the chord type at that moment rather than change dynamically.

This first click wouldn't produce any sound

I think this might be related to browser restriction. It does not allow you to play a sound until you click the page.

Use fragment to share and save chord prog

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Clicking on the white space of the inversion type selector changes the selector text to all the different possible inversions.

Start the piano keyboard from G2

Use Carousel to build a tutorial to teach users how to use our app and use chords in creating music

The tutorial should have two sections:

• Teach users how to use our app
  • They can choose different chord type
  • Show the keyboard mapping
• Teach users some basic music theory knowledge necessary to using the app

C arguments fifth has no symbol

Change the chord type on the root note if the user selects a different chord type, and reset the inversion to none

Highlight the chord when playing the progression

The play button has to click twice to play the chord

There is a lag when playing the keys too quickly

Chord will still be played after resetting

Reset the keyboard after changing the chord type

Append a ghost note to the chord list if a chord is selected, and confirm adding the chord by clicking the note

Copy the chord

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Chord type button group is out of the bound of the small-width window

Some chord symbols overflow the circle

Change the spped of playing

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

The keys without binding triggers keys "undefined0 D#1 F#1"

The problem is that indexof function will return -1 if the list does not contain the key, so the event listener will treat an unbinding key's id as -1.

Clicking the chord inversion button will tirgger a sound

Set back to the original state after playing

Chord type won’t change

If the user select different chord type, the piano will still highlights the keys on the major chord and play the major chord

Set the inversion options based on the chord family the user chooses

The piano sound occasionally has some noise

Notes in chord are wrong

If a chord goes outside of the screen it calls an error and does not play the chord

Verify the half-steps of each chord, better name the chords

Nest the chord type inside a multi-level dropdown

Enharmonic equivalence not correct in chord inversion symbol.

For example, an C minor chord in first inversion should be C/Eb not C/D#

The inversion will be reset to None if changing the chord type