fastify / fast-json-stringify Goto Github PK

Hi!

I'm trying to understand whether what I see is a bug or an expected behavior. String coercion doesn't seem to happen when inside an anyOf (see https://runkit.com/embed/1aoibrghntr5), so my question is should it and if not is there any way to do it?

Thanks!

[
{
id: "string"
}
]

I have json like that. How to build my schema ?

Thanks

Below the proposal to how implement pattern and additional properties.

patternProperties:

Must be an object, where the key is a valid regex and the value is an object.
Example:

"patternProperties": {
    "^S_": { "type": "string" },
    "^I_": { "type": "integer" }
  }

patternProperties will work only for the properties that are not explicitly listed in the properties object.

additionalProperties:

Must be a boolean or an object.
If the is setted to false and there are properties that are not explicitly listed in the properties object we should throw an error.
If additionalProperties is used in conjunction with patternProperties the pecking order will be:
properties -> patternProperties -> additionalProperties
Example:

"additionalProperties": {
  "type": "string"
}

Discussion:

The json schema is very bad documented, so before start to implement these functionalities we need to discuss about few things.

• additionalProperties
  If is setted to { type: 'string' } and any additional property is not a string we have two possible cases:
  1. throw an error
  2. stringify the property as string
• patternProperties
  Basically the same as above, if a property matches to a pattern with { type: 'number' } but the property is not a number we have two cases:
  1. throw an error
  2. stringify the property as number

If I forgot or I didn't see some edge case please write it below.

This is only relevant for Node 6 now, and I think we should drop this feature in the next major release.

Hi all, sorry this is a question and not an issue ... in a library I'm writing fastify-cloudevents, I need to serialize even an object 'data' (usually it's an object, but could be even a Map or a Set ... and with the if/then/else jsonschema feature I should be able to handle it, ok), anyway data is an object provided by consumers of the library, so I can't define more in detail its structure in the schema ... and in this way if I serialize in JSON I only get an empty object, so the solution seems to enable the additionalProperties flag, right ?
But in this case is there a way for me to let the schema handle only attributes of the 'data' object (and filter out other attributes maybe present in the main data structure), like some kind of 'allow-nested-properties' but not other 'top-level-properties' ?
Hope to explain my problem well ... otherwise I can provide more details; note that current code in my repo show the behavior.
Thanks a lot for now, Sandro

Hi, thanks for all the great work!

I'm having a bit of a problem with reusing a schema in Fastify in the response that has a custom format and as I read the code I tracked it down (I think) to the fact Fastify uses this package to compile the response schemas, but since this package uses an internal instance of Ajv it does not have the custom format.

I'm wondering if you'd be open to a PR that would allow you to specify an instance of Ajv to use?

The following is a valid schema, but currently unsupported by fast-json-stringify:

{
    "type": "object",
    "properties": {
      "stringOrNumber": {"type": ["string", "number"], "maxLength": 10}
    }
}

When trying to validate against a JSON schema containing anyOf type, the parser throw an error.

{
  "$schema": "http://json-schema.org/draft-04/schema#",
  "properties": {
    "key1": {
      "anyOf": [
        {
          "type": "string"
        },
        {
          "type": "object"
        }
      ]
    }
  },
  "additionalProperties": false
}

throws undefined unsupported.

I'll make a PR with a failing test case so it can be clearer.

As titled.

Co-related to my issue raised here:
#44

I have a use case to just have a loose object inside of a well-defined schema.

I suppose this issue would satisfy this use case as well:
#29

because then I could just specify the Object had a pattern property of ".*" with types ['string', 'number', 'null', 'boolean', 'object', 'array'] and then refs in the properties and items. This may even be better (read: more feasible) than loose Objects because it still forces you to be declarative about the types of the expected properties in the Object.

However, this still seems like abusive use of the multiple typing. Unfortunately, as much as I'd like to say that it was always possible to predict the types of properties in all of the Objects I'm attempting to stringify, there's always going to be a use case for Objects containing loosely-defined payloads.

Any thoughts on this as a feature? Or thoughts on solving it with the multi-typing functionality issue?

If you pass just the additionalProperties and not the properties, fast-json-stringify will throw.
properties should be optional.

Here the line that must be changed.

See pinojs/pino#113 and pinojs/pino#112.

npm doesn't reflect last uglify-es version (3.3.10). Reason: uglify-es is no longer maintained,

mishoo/UglifyJS#3067

If a nested object has a property, which is also present in the parent, it is not serialized.

I've already created a test case.

'use strict'

const test = require('tap').test
const build = require('..')

test('nested objects with same properties', (t) => {
  t.plan(1)

  const schema = {
    title: 'nested objects with same propertie',
    type: 'object',
    properties: {
      stringProperty: {
        type: 'string'
      },
      objectProperty: {
        type: 'object',
        additionalProperties: true
      }
    }
  }
  const stringify = build(schema)

  try {
    const value = stringify({
      stringProperty: 'string1',
      objectProperty: {
        stringProperty: 'string2',
        numberProperty: 42
      }
    })
    t.is(value, '{"stringProperty":"string1","objectProperty":{"stringProperty":"string2","numberProperty":42}}')
  } catch (e) {
    t.fail()
  }
})

Expected result

{
  "stringProperty": "string1",
  "objectProperty": {
    "stringProperty": "string2",
    "numberProperty": 42
  }
}

Actual result

{
  "stringProperty": "string1",
  "objectProperty": {
    "numberProperty": 42
  }
}

Hi. Cloudflare Edge Workers allow you to write javascript that runs in an embedded V8 environment in all >150 of Cloudflare's data centres at the 'edge'. However for security reasons they don't allow you to use eval() and new Function().

I was wondering if there's a way of using fast-json-stringify given these constraints. I can see that new Function() is used by the library here:

I had a quick look through the source code and can't think of a way of removing new Function(), it seems very central to how the library works. But then again I'm not very advanced in js so thought I'd post a quick issue to ask.

One thought I'd did have: could there somehow be a way of using fast-json-stringify to generate the javascript needed for a specific schema in a code-generation step in advance, and then just ship that js code to cloudflare? I've done code-generation in golang before (strongly typed but no generics so it's a common approach) but I'm not very advanced in javascript to know if this could work in this case. I haven't looked into how fast-json-stringify works enough to know if this makes any sense so ignore me if it doesn't.

Thanks. Mike

PS: the environment isn't node.js in cloudflare's edge - it's essentially a V8 service-worker. Not sure if that's relevant - perhaps fast-json-stringify relies on other node.js-specific stuff so I should just give up on this idea entirely.

Version 5.4.0 of ajv was just published.

This version is covered by your current version range and after updating it in your project the build failed.

ajv is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

In an ill advised effort to use the new multitype tuple feature to allow any type in an object in any position of an Array, I think I've uncovered a weird bug:

here is my schema for an Array property "args":

        args: {
            items: [
                {
                    type: 'object',
                    patternProperties: {
                        '.*': {
                            type: 'string',
                        },
                    },
                },
                {
                    type: 'object',
                    patternProperties: {
                        '.*': {
                            type: 'number',
                        },
                    },
                },
                {
                    type: 'object',
                    patternProperties: {
                        '.*': {
                            type: 'null',
                        },
                    },
                },
                {
                    type: 'object',
                    patternProperties: {
                        '.*': {
                            type: 'boolean',
                        },
                    },
                },
            ],
            type: 'array',
        },

and then here is my object:

const obj = {
    args: [
        'foo', 
        {
            foo: 1,
            bar: 'foo',
        }
     ],
};

This is the result:

{"args":[,{"foo":"1","bar":"foo"}{"foo":1,"bar":null}{"foo":null,"bar":null}{"foo":true,"bar":true}]}

I was just attempting to use this for which it wasn't intended, but at the same time, this returns an invalid JSON string, which I don't think is desirable behavior.

Hello @addaleax!
Me and @mcollina are working on this project, Fastify a web framework focused on performances and other very nice stuff :)
Part of the project is this module, that as you can easily image is a schema based json serializator.

I saw your talk at NodeConfBarcellona where you talked about character encoding.
We had some little trouble with that and our solution was this one.
I was wondering if you'd like to check out the function, and help us to improve it :)

Thank you and have a nice day! :)

I use webpack on the server side. ES 6 expects static imports. As a result 'long' and 'uglify-es' emit the following warnings. In general, I believe it is bad practice to include dynamic requirements in a module - even while a dynamic import is being considered in ES.

Let's think of a better way to handle adding these capabilities. I have replaced my project path with '/path/to/project' in the traces below:

WARNING in ./node_modules/fast-json-stringify/index.js
Module not found: Error: Can't resolve 'long' in '/path/to/project/node_modules/fast-json-stringify'
 @ ./node_modules/fast-json-stringify/index.js 9:11-26
 @ ./node_modules/fastify/lib/reply.js
 @ ./node_modules/fastify/fastify.js
 @ ./es6/lib/app/index.js
 @ ./es6/index.js

WARNING in ./node_modules/fast-json-stringify/index.js
Module not found: Error: Can't resolve 'uglify-es' in '/path/to/project/node_modules/fast-json-stringify'
 @ ./node_modules/fast-json-stringify/index.js 608:13-33
 @ ./node_modules/fastify/lib/reply.js
 @ ./node_modules/fastify/fastify.js
 @ ./es6/lib/app/index.js
 @ ./es6/index.js

WARNING in ./node_modules/fast-json-stringify/index.js
Module not found: Error: Can't resolve 'uglify-es/package.json' in '/path/to/project/node_modules/fast-json-stringify'
 @ ./node_modules/fast-json-stringify/index.js 609:24-57
 @ ./node_modules/fastify/lib/reply.js
 @ ./node_modules/fastify/fastify.js
 @ ./es6/lib/app/index.js
 @ ./es6/index.js

If a string begins with a double quote and it never contains another one it is stringified without escaping the double quote.
The following test fails

'use strict'

const test = require('tap').test
const validator = require('is-my-json-valid')
const build = require('..')

test('render a single quote as JSON', (t) => {
  t.plan(2)

  const schema = {
    type: 'string'
  }
  const toStringify = '" double quote'

  const validate = validator(schema)
  const stringify = build(schema)
  const output = stringify(toStringify)

  t.equal(output, JSON.stringify(toStringify))
  t.ok(validate(JSON.parse(output)), 'valid schema')
})

This is the output of the test

    +++ found
    --- wanted
    -"\" double quote"
    +"" double quote"

The test does not fail if there is another double quote anywhere in the string...

After some test I saw a general regression in the benchmarks.
Both in Node v4 and v6.

The bench:

JSON.stringify array x 3,796 ops/sec ±0.83% (92 runs sampled)
fast-json-stringify array x 1,629 ops/sec ±1.20% (90 runs sampled)

JSON.stringify long string x 13,905 ops/sec ±0.75% (93 runs sampled)
fast-json-stringify long string x 13,805 ops/sec ±0.86% (91 runs sampled)

JSON.stringify short string x 5,121,081 ops/sec ±0.90% (88 runs sampled)
fast-json-stringify short string x 4,957,411 ops/sec ±0.85% (90 runs sampled)

JSON.stringify obj x 1,814,632 ops/sec ±0.93% (87 runs sampled)
fast-json-stringify obj x 1,583,802 ops/sec ±0.79% (92 runs sampled)

I'll do more test.
Related: fastify/fastify#34

An invalid JSON schema can cause very unreadable errors while generating. We are already depending on ajv, so we might as well validate the schema before generating the function.

Moving this issue fastify/fastify#331 (comment) to here

Hi,

I am playing with the framework to know if I should keep using it and this crashes the server when I npm server. Not sure why and I couldn't find anything in the docs. Thanks for your insight!

const userSchema = {
  schema: {
    response: {
      200: {
        type: 'object',
        properties: {
          users: { type: 'array' }
        }
      }
    }
  }


TypeError: Cannot read property '$ref' of undefined
    at buildArray (/Users/om/Documents/projects/ch/node-api/node_modules/fast-json-stringify/index.js:401:19)
    at nested (/Users/m/Documents/projects/ch/node-api/node_modules/fast-json-stringify/index.js:518:19)
    at Object.keys.forEach (/Users/m/Documents/projects/ch/node-api/node_modules/fast-json-stringify/index.js:365:18)
    at Array.forEach (native)
    at buildObject (/Users/m/Documents/projects/ch/node-api/node_modules/fast-json-stringify/index.js:352:40)
    at build (/Users/m/Documents/projects/crowdhub/node-api/node_modules/fast-json-stringify/index.js:56:14)
    at getValidatorForStatusCodeSchema (/Users/m/Documents/projects/ch/node-api/node_modules/fastify/lib/validation.js:15:10)
    at /Users/m/Documents/projects/ch/node-api/node_modules/fastify/lib/validation.js:21:21
    at Array.reduce (native)
    at getResponseSchema (/Users/m/Documents/projects/ch/node-api/node_modules/fastify/lib/validation.js:20:22)
    at build (/Users/m/Documents/projects/ch/node-api/node_modules/fastify/lib/validation.js:44:28)
    at _fastify.after (/Users/m/Documents/projects/ch/node-api/node_modules/fastify/fastify.js:400:7)
    at Function._encapsulateThreeParam (/Users/m/Documents/projects/ch/node-api/node_modules/avvio/boot.js:271:7)
    at Boot.callWithCbOrNextTick (/Users/m/Documents/projects/ch/node-api/node_modules/avvio/boot.js:223:5)
    at Boot._after (/Users/m/Documents/projects/ch/node-api/node_modules/avvio/boot.js:180:26)
    at process.nextTick (/Users/m/Documents/projects/ch/node-api/node_modules/avvio/plugin.js:30:5)

We have a logging contract which says timestamp should be called @timstamp and version should be @version. This module throws when it tries to serialise it (on node@6 at least).

Example:

require('fast-json-stringify')({
    title: 'Logging Schema',
    type: 'object',
    properties: {
        '@version': {
            type: 'integer',
        },
    },
});

undefined:61
      if (obj.@version !== undefined) {
              ^
SyntaxError: Invalid or unexpected token
    at build (/Users/simbekkh/repos/node-fiaas-logger/node_modules/fast-json-stringify/index.js:80:11)
    at Object.<anonymous> (/Users/simbekkh/repos/node-fiaas-logger/sup.js:5:19)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:393:7)
    at startup (bootstrap_node.js:150:9)

Hi, I have an object whose keys represents date in the format YYYY-MM-DD and I am trying to build a schema that matches it, but without any result. It looks like.

const fastJson = require('fast-json-stringify')
const stringify = fastJson({
  title: 'RabbitMQ Message',
  type: 'object',
  patternProperties: {
    '^\d{4}-\d{2}-\d{2}$': {
      type: 'string'
    }
  }
})

console.log(stringify({
  '2018-01-01': "foo",
}))

returns {}.

Using '^[0-9]{4}-[0-9]{2}-[0-9]{2}$'works, instead

你好你好，我在学习fast-json项目的过程发现原生的JSON序列化效率要更高一些。也可能是我测试方法存在缺陷，请指正。
测试脚本：https://www.cjwddz.cn/blog/2018-05-29-front-end/serialize-compare/

as titled

See https://ajv.js.org/keywords.html#ifthenelse

Hi,

I got a schema like that for a route on fastify.

{
  "200": {
    "type": "object",
    "allOf": [
      {
        "type": "object",
        "required": [
          "name"
        ],
        "properties": {
          "name": {
            "type": "string"
          },
          "tag": {
            "type": "string"
          }
        }
      },
      {
        "required": [
          "id"
        ],
        "type": "object",
        "properties": {
          "id": {
            "type": "integer"
          }
        }
      }
    ]
  },
  "default": {
    "type": "object",
    "required": [
      "code",
      "message"
    ],
    "properties": {
      "code": {
        "type": "integer"
      },
      "message": {
        "type": "string"
      }
    }
  }
}

And sadly, my validation function for the 200 (responseSchemaDef[statusCode]) look like this :

$main(obj) {
      var json = '{'
      var addComma = false
  
      json += '}'
      return json
}

I'm guessing that allOf is not available, but it's a JSON schema official keywork.

Can you add it?

Same for oneOf ?

Regards

Version 2.17.0 of is-my-json-valid was just published.

This version is covered by your current version range and after updating it in your project the build failed.

is-my-json-valid is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

as titled. A good examples are the one on http://github.com/mcollina/pino

Version 3.0.26 of uglify-es just got published.

This version is covered by your current version range and after updating it in your project the build failed.

As uglify-es is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Your Greenkeeper Bot 🌴

Gist with the issue here

Node Version: v8.0.0
fast-json-stringify-version: 0.15.1
OS: Windows 10, 64bit

References that do not have a hash cause an exception.

Good:

const goodSchema = {
  title: 'Example Schema',
  type: 'object',
  properties: {
    nickname: {
      $ref: 'strings#'
    }
  }
}

Bad:

const badSchema = {
  title: 'Example Schema',
  type: 'object',
  properties: {
    nickname: {
      $ref: 'strings' // <-------- note the missing hash
    }
  }
}

Exception that is thrown looks like this:

...\node_modules\fast-json-stringify\index.js:354
  var walk = ref[1].split('/')
                   ^
TypeError: Cannot read property 'split' of undefined

As far as I can tell, not having the hash is valid. example1, example2

It looks like here it should handle the case where there is no hash present - it could skip the walk.

Thoughts?

Thank you for your work with this library, it's incredibly useful. 😄

The dependency ajv was updated from 6.5.3 to 6.5.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ajv is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

The dependency ajv was updated from 6.5.4 to 6.5.5.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

ajv is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Your Greenkeeper Bot 🌴

I did this bench, and the result is remarkable.

'use strict'

const benchmark = require('benchmark')
const suite = new benchmark.Suite()
const date = new Date()

suite
  .add('toISOString()', function () {
    date.toISOString()
  })
  .add('getTime()', function () {
    date.getTime()
  })
  .on('cycle', function (event) {
    console.log(String(event.target))
  })
  .on('complete', function () {})
  .run()

Result:

toISOString() x 2,132,610 ops/sec ±0.84% (91 runs sampled)
getTime() x 86,037,830 ops/sec ±0.96% (92 runs sampled)

Should we move from .toISOString() to .getTime()?

Are there plans to support streams or is there already an example?

For instance, a large collection of schema objects sent to the client in chunks.

Example:

const fastJson = require('fast-json-stringify')
const stringify = fastJson({
  type: 'object',
  properties: {
    field: { type: 'string' }
  }
})

console.log(stringify({ field: null }))
// => TypeError: Cannot read property 'toString' of null

What we want to do in the above case?

• 'null'
• ''

Other options?

Support for 64bit integers as numbers instead of strings would be very useful. The use case being 3rd-party APIs that enforce it.

From my understanding, the $asNumber function could simply not convert the input to a Number and it would pretty much work as it (since the source long would be a string anyway). However, I don't know if that would introduce a backward compatibility issue.

Alternatively, the string could be validated with regex, but that might be too slow.

I thought about adding a long type but that doesn't exist in the JSON Schema specification.

What do you think?

the array case in the benchmarks has become slower than JSON.stringify.

Version 2.18.0 of is-my-json-valid was just published.

This version is covered by your current version range and after updating it in your project the build failed.

is-my-json-valid is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

I'd like to have a little different model structure internally in my app than returning it externally via API. Unfortunately, using fastify and fast-json-stringify this can't be done as fast-json-stringify does not use the objects toJSON function to map the data somehow.

I guess it could be on purpose to improve the performance, but this is a little bit unintuitive to do:

reply.send(model.toJSON());

and what even worse:

const models = [arrayOfModels];
reply.send(models.map(model => model.toJSON()));

This doesn't make much sense as there's no difference if I have to do this manually or if it would be done by fast-json-stringify - just as I'd expect.

Here's a little reproduction:

const fastJson = require("fast-json-stringify");

const stringify = fastJson({
    type: "object",
    properties: {
        groups: {
            type: "array",
            items: {
                type: "string"
            }
        }
    }
});

class User {
    constructor() {
        this.groups = [{ name: "admin" }, { name: "subscriber" }];
    }

    toJSON() {
        return {
            ...this,
            groups: this.groups.map(group => group.name)
        };
    }
}

const user = new User();

console.log(stringify(user)); // returns: {"groups":["[object Object]","[object Object]"]}
console.log(JSON.stringify(user)); // returns: {"groups":["admin","subscriber"]}

Could you somehow relate to this issue? And maybe you have some idea for a solution in fastify?

I'm unable to set a response schema for an array in Fastify.

Version

• [email protected]
• [email protected]

Error

/Users/seb/Code/sebdeckers/fastify/node_modules/fast-json-stringify/index.js:559
      } else throw new Error(`${schema} unsupported`)
             ^

Error: [object Object] unsupported
    at nested (/Users/seb/Code/sebdeckers/fastify/node_modules/fast-json-stringify/index.js:559:20)
    at buildArray (/Users/seb/Code/sebdeckers/fastify/node_modules/fast-json-stringify/index.js:475:14)
    at build (/Users/seb/Code/sebdeckers/fastify/node_modules/fast-json-stringify/index.js:76:14)
    at getValidatorForStatusCodeSchema (/Users/seb/Code/sebdeckers/fastify/lib/validation.js:15:10)
    at /Users/seb/Code/sebdeckers/fastify/lib/validation.js:21:21
    at Array.reduce (<anonymous>)
    at getResponseSchema (/Users/seb/Code/sebdeckers/fastify/lib/validation.js:20:22)
    at build (/Users/seb/Code/sebdeckers/fastify/lib/validation.js:47:28)
    at _fastify.after (/Users/seb/Code/sebdeckers/fastify/fastify.js:411:7)
    at Function._encapsulateThreeParam (/Users/seb/Code/sebdeckers/fastify/node_modules/avvio/boot.js:282:7)

Reproducible Code

const fastify = require('fastify')({logger: true})

fastify.route({
  url: '/',
  method: 'GET',
  schema: {
    response: {
      200: {
        type: 'array',
        items: {
          hello: { type: 'string' }
        }
      }
    }
  },
  handler: async (request, reply) => {
    reply.send([
      { hello: 'world' }
    ])
  }
})

fastify.listen(0, () => {
  console.log(`Listening at port ${fastify.server.address().port}`)
})

As titled, test to reproduce:

test('nested additionalProperties', (t) => {
  t.plan(1)
  const stringify = build({
    title: 'additionalProperties',
    type: 'object',
    properties: {
      ap: {
        type: 'object',
        additionalProperties: { type: 'string' }
      }
    }
  })

  let obj = { ap: { value: 'string' } }
  t.equal('{"ap":{"value":"string"}}', stringify(obj))
})

The output:

  nested additionalProperties
  not ok Cannot convert undefined or null to object
    stack: |
      buildObject (index.js:267:10)
      nested (index.js:381:19)
      Object.keys.forEach (index.js:279:20)
      Array.forEach (native)
      buildObject (index.js:267:34)
      build (index.js:28:14)
      Test.test (test/additionalProperties.test.js:186:21)
    at:
      line: 267
      column: 10
      file: index.js
      function: buildObject
    type: TypeError
    test: additionalProperties
    source: |
      Object.keys(schema.properties).forEach((key, i, a) => {

http://npm.im/flatstr

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

Is it a good idea to use this module to create a module for valueEncoding in LevelDB?

Hi, while we support many features we should still track which JSON-Schema features are covered right now. We should add the official JSON-schema tests-suite as a submodule and write against it. In that way, we can create TODO what's is missing and motivate people to fulfill it.

Node branch: https://github.com/json-schema-org/JSON-Schema-Test-Suite/tree/node
Up-to-date: https://github.com/json-schema-org/JSON-Schema-Test-Suite

I'm using this in conjunction with Fastify, and am trying to pass back some SQL results. Many of the fields can be null, or contain a value.

I haven't figured out a way to use this and say that a value, for example deletedAt is a string, but may also be null.

Is that possible?

I ran into this issue when trying to create a JSON schema for fastify. We have a property that can either be null or be an object. I've created a simple example to reproduce the issue:

const fastJson = require("fast-json-stringify")

const mySchema = {
    type: "object",
    properties: {
        myProperty: {
            anyOf: [
                {
                    type: "object",
                    properties: {
                        propertyA: {
                            type: "string"
                        }
                    }
                },
                {
                    type: "null",
                }
            ]
        }
    }
}

const stringify = fastJson(mySchema)

let json = stringify({
    myProperty: null
})
console.log(json)

json = stringify({
    myProperty: {
        propertyA: "hello"
    }
})
console.log(json)

It looks like fast-json-stringify generates invalid code:

ReferenceError: $mainmyPropertyundefined is not defined
    at $main (eval at build (/test/fast-json-stringify/node_modules/fast-json-stringify/index.js:99:20), <anonymous>:77:9)
    at Object.<anonymous> (/test/fast-json-stringify/index.js:31:8)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)
    at Function.Module._load (module.js:491:3)
    at Function.Module.runMain (module.js:684:10)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:608:3

Hi. I can see that this lib supports anyOf. But according to description it looks like it acts like oneOf.
For example in ajv anyOf should match 1 or more and oneOf should match exactly one.

Also it seems working correctly if anyOf items differ by type. However if they not, it will fail and just take the last object to validate.

Under the hood it converts anyOf to if-else clause with ajv.validate. But ajv supports oneOf and allOf. Why it just not pass the whole parent object (that has oneOf or anyOf) directly to ajv?

test('object with multiple objects', (t) => {
  t.plan(2)

  const schema = {
    title: 'object with multiple objects',
    type: 'object',
    properties: {
      prop: {
        anyOf: [{
          type: 'object',
          properties: {
            str: {
              type: 'string'
            },
            str1: {
              type: 'string'
            }
          }
        },{
          type: 'object',
          properties: {
            str: {
              type: 'string'
            }
          }
        }, {
          type: 'object',
          properties: {
            str1: {
              type: 'string'
            }
          }
        }]
      }
    }
  }
  const stringify = build(schema)

  try {
    const value = stringify({
      prop: {str: 'string', str1: 'string1'}
    })
    t.is(value, '{"prop":{"str":"string", "str1":"string1"}}')
  } catch (e) {
    t.fail()
  }
})

    +++ found
    --- wanted
    -{"prop":{"str":"string", "str1":"string1"}}
    +{"prop":{"str1":"string1"}}

I've tried to make a fix for that, but seems I'm missing something and if I add the code it throws ajv is not defined exception during tests.