fcaviggia / classification-banner Goto Github PK

I would like to change the Licence of this project from GNU Public Licence version 2 (GPLv2) to Apache Public Licence 2.0 (APL2.0) to allow people to utilize this software without having to submit changes back to the project. I believe that this will allow for better use in the DOD/IC without the requirements to give back everything - however, it would still remain open source as a reference model.

When resizing a VNC window of a desktop that has the classification-banner running, it crashes.

I will open a PR to address this issue.

there is a ConfigParser error that pops up. This is because ConfigParser has now been changed to configparser, so it is unable to correctly find the module.

Is there an easy way to offset the banner from the y value that's set? I'm using CentOS 7 with XFCE and there is a ~20 pixel gap between the taskbar and the banner. I'm trying to get the banner to rest exactly below the taskbar.

I went into the code and tried doing a simple offset on the top.window.move self.y_location - 20 but the bar doesn't seem to actually change position and offset. Conversely if I test with a self.y_location + 20 the bar moves down, so there is something that causes it to not accept negative values

python_requires should probably be 2.6 and not 2.7 if this is still supposed to work on RHEL6.

Also data_files is incorrect. The format is a tuple of (install path, file name). Currently what is being installed is /usr/lib/python2.6/site-packages/classification_banner-1.7.0-py2.6.egg/share/banner.conf/classification-banner-screenshot.png

See attached... can help anyway I can.

On a fairly basic arch install running the script resulted in "No such file or directory" being spat out when calling get_user().

My solution was to replace os.getlogin() with getpass.getuser()

Edit - Replaced with pull request

Prior to installation on a CentOS 7.2.1511 VM, I was able to right-click, select 'Open in terminal', and begin typing into the terminal window because it was focused. After installation, I have to click inside the terminal window to begin typing because the focus is not happening automatically.

I tried modifying the classification-banner.desktop file, since I saw a reference to terminal, and I changed the terminal=false to terminal=true, but this just launched an active terminal window at login, but it did not present the classification banner in the desktop.

The title bars of maximized windows are obscured by the banner. Is there a way to have the banner block windows like on the Windows NetBanner, or is there a workaround for metacity (or something) to prevent this?

I don't know exactly why I'm experiencing this but my bottom banner does not show. If I modify line 71 to subtract 5 from the vres it does show.

If the goal is to still support RHEL6, then either the information provided by sys.version_info should be accessed via index number or sys.hexversion should be used as suggested in https://stackoverflow.com/a/3018075/1698660

I will put in a pull request with my suggested change.

I'd like to request an option that disables the "press escape to hide" feature completely (wherein pressing ESC will not hide the classification banner at all), preferably controlled from either the command line or the config file (/etc/classification-banner).

Checking with echo $DISPLAY shows :0, when attempting to run classification-banner it complains with an error "DISPLAY environment variable not set."

the bar appears correctly initially, but if you escape it to make it disappear, it will reappear in the middle of the screen

If there is a configuration error (message or color option omitted), the default should be some form of CLASSIFICATION UNKNOWN. Possibly use the purple color for classified not, level not specified or #00ffff

Window management keyboard shortcuts are able to resize the banner to be full-screen or half-screen. I often trigger this behavior trying to resize my active windows & the Classification Banner is seen as the target. Is there a mechanism to disable window management from applying this behavior?

As our implementation is ran as a system process, the user is forced to terminate their session to restore the original behavior.

See below for sample scenarios

With pulling in change #23 python 2.6 is no longer supported breaking native support on RHEL6.

Experienced on RHEL 7.2.

When the classification banner is running, new windows will open without focus.
To recreate:

1. Log-in to RHEL and start classification banner
2. Right click on desktop and click "Open in Terminal"
3. Note that the focus is still on the desktop. You cannot type into the terminal window unless you click on the new terminal window.
4. Kill the classification banner
5. Repeat step 2.
6. Note that the window is in focus and you can immediately type into it without clicking.

This issue also prevents firefox from bringing new windows into focus. If Firefox is running maximized and the user clicks on a link which opens a new window, the window is opened in the background and Gnome 3 shows a notification with message: Firefox Web Browser - "" is ready. This forces the user to click this annoying gnome 3 message to bring up the new window.

I am not a python expert by any stretch of the imagination...
I downloaded the classification-banner-master.zip and moved it to my system (offline)
Unzipped the file in my /root directory to the classification-banner-master directory
ran:
python setup.py install
in the classification-banner-master directory
Got no errors.
only thing installed on the system was a /usr/bin/classification-banner file that has nothing in it.
and a link to that file /bin/classification-banner.
Trying to run either of these just gives an error.
Does the zip file need to be in a specific place before installing?
Are there other steps that you do not have documented?

RHEL 7.6
STIG'd v2r4
Limited GNOME desktop running