fedora-python / crypt_r Goto Github PK

I'm a lost at the renaming, couldn't you have keep it with the same previous name, ie crypt?

I had hoped that installing passlib 1.7.4 + crypt_r with Python 3.13 would work out of the box.

However passlib (which does not seem to be updated soon) does from crypt import crypt ... ,
so a key point is that the package name (not its publication name, I'm fine with crypt_r)
must be crypt and the provided function must be crypt for this to work.

There should not be any issue with Python 3.13 because there is no crypt, it was removed, that's the point.

There should not be any issue with prior versions because there is a crypt there and it is the same as this one,
so declaring a dependency conditional on the version would be enough. The new crypt_r module should declare
that it requires Python 3.13 or above.

What am I missing?

We should add a changelog (to REDAME?). It should say what changes since the fork from CPython and link to CPython 3.12.3 changelog for previous changes.

We should add some metadata to pyproject.toml.

• minimal Python version
• license
• classifiers
• link(s) this repository
• ...

Could not install crypt_r on Mac.

% pip install crypt-r

Collecting crypt-r
Using cached crypt_r-3.13.1.tar.gz (20 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... done
Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: crypt-r
Building wheel for crypt-r (pyproject.toml) ... error
error: subprocess-exited-with-error

× Building wheel for crypt-r (pyproject.toml) did not run successfully.
│ exit code: 1
╰─> [26 lines of output]
running bdist_wheel
running build
running build_py
creating build
creating build/lib.macosx-10.9-x86_64-cpython-311
copying src/crypt_r.py -> build/lib.macosx-10.9-x86_64-cpython-311
copying src/crypt.py -> build/lib.macosx-10.9-x86_64-cpython-311
running egg_info
writing src/crypt_r.egg-info/PKG-INFO
writing dependency_links to src/crypt_r.egg-info/dependency_links.txt
writing top-level names to src/crypt_r.egg-info/top_level.txt
reading manifest file 'src/crypt_r.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching '*.h' under directory 'src'
adding license file 'LICENSE'
writing manifest file 'src/crypt_r.egg-info/SOURCES.txt'
running build_ext
building '_crypt_r' extension
creating build/temp.macosx-10.9-x86_64-cpython-311
creating build/temp.macosx-10.9-x86_64-cpython-311/src
clang -DNDEBUG -fwrapv -O2 -Wall -fPIC -O2 -isystem /<...>/include -fPIC -O2 -isystem /Users/serg/opt/anaconda3/envs/tokenizer/include -I/Users/<...>/include/python3.11 -c src/_crypt_r.c -o build/temp.macosx-10.9-x86_64-cpython-311/src/_crypt_r.o
src/_crypt_r.c:9:10: fatal error: 'crypt.h' file not found
#include <crypt.h>
^~~~~~~~~
1 error generated.
error: command '/usr/bin/clang' failed with exit code 1
[end of output]

note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for crypt-r
Failed to build crypt-r
ERROR: Could not build wheels for crypt-r, which is required to install pyproject.toml-based projects