felflare / rpunct Goto Github PK

First, thanks a lot for providing this package :)

Currently, the requirements.txt, and thus the dependencies in the setup.py are for very specific versions of Pytorch etc. This shouldn't be the case if you want this package to be used as a general library (think of a second package that would do the same but ask for an incompatible version of PyTorch and would prevent any possible installation of the two together). The end user might also be needing a more recent version of PyTorch.
Given that PyTorch is almost always backward compatible, and quite stable, I think the requirements for it could be changed from ==1.8.1 to >=1.8.1. I believe the same would be true for the other packages.

Hi,

Please update requirement.txt file to fix this error.
ERROR: Could not find a version that satisfies the requirement torch==1.8.1 (from rpunct) (from versions: 1.11.0, 1.12.0, 1.12.1, 1.13.0, 1.13.1)
ERROR: No matching distribution found for torch==1.8.1

Thanks

Is there possibility to use more languages?

Hi, I am trying to run rpunct but getting following error in the console.
This is the error from the console:
File "app.py", line 3, in
rpunct = RestorePuncts()
File "/home/beck/miniconda3/envs/restore_punctuation/lib/python3.7/site-packages/rpunct/punctuate.py", line 18, in init
args={"silent": True, "max_seq_length": 512})
File "/home/beck/miniconda3/envs/restore_punctuation/lib/python3.7/site-packages/simpletransformers/ner/ner_model.py", line 212, in init
"'use_cuda' set to True when cuda is unavailable."
ValueError: 'use_cuda' set to True when cuda is unavailable.Make sure CUDA is available or set use_cuda=False.

How can I pass argument to RestorePuncts() to set cuda to False?

I forked this repository (link here) to fix the outdated dependencies and incompatibility with non-CUDA machines. If anyone needs these fixes, feel free to install from the fork:

pip install git+https://github.com/samwaterbury/rpunct.git

Hopefully this repository is updated or another maintainer is assigned. And thanks to the creator @Felflare, this is a useful tool!

This project is super cool and I believe it is useful for many applications. May I know the license of this project?
Additionally, it would be nice to include a LICENSE file in your repo!