GithubHelp home page GithubHelp logo

fevol / obsidian-criticmarkup Goto Github PK

View Code? Open in Web Editor NEW
120.0 120.0 2.0 936 KB

Annotate notes with comments and suggestions using CriticMarkup in Obsidian

License: MIT License

JavaScript 1.12% TypeScript 79.96% SCSS 5.48% CSS 0.01% Svelte 13.44%
criticmarkup editor obsidian-md obsidian-plugin

obsidian-criticmarkup's People

Contributors

fevol avatar kometenstaub avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Forkers

leiyanhua newtypo

obsidian-criticmarkup's Issues

[BUG] Comments are not hidden

Comments are not hidden even though I've selected "inline-icon" or "inline" rendering selected.

Screenshot 2024-02-07 at 03 25 14 Screenshot 2024-02-07 at 03 25 10

Very high-quality plugin, very appreciated! Thanks and congrats :)

Edits of the suggestion

Incredible plugin, thank you so much for working on it! I'm wondering if it would be possible to add a setting so that edits to suggestions don't get crossed out if edited but actually just permanently edit the suggestion.

double period

In Suggestion mode, when typing one period (.), Commentator adds another period and deletes one space from the following word (I have deletions in front in this example)
Also, in editing (alt), when adding a period it deletes one space of code of the deletion preview following.


Debugger data (do not alter)

plugin_version: "0.2.0"
platform: "Desktop"
framework_version: "1.5.8"
obsidian_version: "1.5.11"

Substitution showing up wrong in Preview

When making a substitution (deletion+addition) and going to "Preview accepting all", Commentator shows the deletion instead of the addition. When I then go and "Accept all suggestion" text comes out right with the deletion deleted and the addition showing up.

Example:
Una forza mostruosa si sollevò dentro {~~di lui ~>M04 ~~}e si riversò fuori con lingue azzurrine.
Preview accepting all: Una forza mostruosa si sollevò dentro di lui e si riversò fuori con lingue azzurrine. (wrong)
Text after accepting al suggestions: Una forza mostruosa si sollevò dentro M04 e si riversò fuori con lingue azzurrine. (right)

Style wrong in Global view

comment only show content, but in Global view, for author, it will show {"author":"what"}@@xxxx

image

expect:
show only content in Global view.

[BUG] Non-markdown files indexed in database

I used the Edit History plugin, which creates a xxx.md.edtz file at the same location as the file. Every time I modify the note, it creates an edit history record (compressed), similar to the commit history of Git.

This quite excellent plugin, obsidian-criticmarkup, also takes effect on this xxx.md.edtz file, making it impossible for me to manage note versions. I suggest that the obsidian-criticmarkup plugin could have an include / exclude mechanism so that I can choose which files to take effect / not take effect.

image

The compressed edit history was unexpectedly captured by obsidian-criticmarkup.

thx :)

Add option to show comments next to text

First of all thank you so much for developing this plugin! I am really looking forward to this!

Currently, I modified the obsidian comment to be shown like in this picture, which sadly leads to an issue when having an internal link inside it.

image

image

Is it possible to style the comments in a similar but functional way? At least in a future release?

“comment gutter fold button” and the comment area are unable to show up

User report

Description: “comment gutter fold button” didn't show and I can't add content of the new comment because the area didn't show up. I have close all plugins and css snippets, and change to default theme. After I restarted obsidian, It also didn't show.
Then I open the developer console. The operations about comment didn't return any information in the console.
image

However, when I open a new vault which has some plugins and css snippets, the button shows up. I don't know why.
image

another issue, when I use the command "mark as comment", it becomes like this:
image


Debugger data (do not alter)

plugin_version: "0.2.0"
platform: "windows 11"
framework_version: "1.4.16"
obsidian_version: "1.5.8"

Set wrong metadata

Detail:
if you click set metadata -> set time, it will be {++"time":1709865543@@xxx++} , you can see it is not surrounded metadata with {} . same situation for set author.
image

example:
set metadata -> set author to set author to me
expect:
{++{"author":"me"}@@xxx++}

actual:
{++"author":"me"@@xxx++}

word jumping on deletions

In suggestion mode, if I try to correct what I just wrote and put the cursor on a word I previously wrote, on deletion, the cursor jumps and deletes letters of another word. Sam happens when I try to delete the last word I just wrote, the cursor jumps to a previous word. Also, the appa froze.


Debugger data (do not alter)

plugin_version: "0.2.0"
platform: "Desktop"
framework_version: "1.5.8"
obsidian_version: "1.5.11"

Bug: Reading view stays rendered after turning the renderer off.

Hi fevol!

Steps to reproduce:

  1. Install the plugin.
  2. Get some critic markup file to test with.
  3. Open it in READING mode. You should see the markup, since the renderer is enabled by default.
  4. Go to the settings, turn off the READING renderer.
  5. Observe that the critic markup is still rendered.

Issue: step 4 should not be rendering the critic markup in reading mode.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.