fevol / obsidian-criticmarkup Goto Github PK
View Code? Open in Web Editor NEWAnnotate notes with comments and suggestions using CriticMarkup in Obsidian
License: MIT License
Annotate notes with comments and suggestions using CriticMarkup in Obsidian
License: MIT License
Incredible plugin, thank you so much for working on it! I'm wondering if it would be possible to add a setting so that edits to suggestions don't get crossed out if edited but actually just permanently edit the suggestion.
In Suggestion mode, when typing one period (.), Commentator adds another period and deletes one space from the following word (I have deletions in front in this example)
Also, in editing (alt), when adding a period it deletes one space of code of the deletion preview following.
plugin_version: "0.2.0"
platform: "Desktop"
framework_version: "1.5.8"
obsidian_version: "1.5.11"
When making a substitution (deletion+addition) and going to "Preview accepting all", Commentator shows the deletion instead of the addition. When I then go and "Accept all suggestion" text comes out right with the deletion deleted and the addition showing up.
Example:
Una forza mostruosa si sollevò dentro {~~di lui ~>M04 ~~}e si riversò fuori con lingue azzurrine.
Preview accepting all: Una forza mostruosa si sollevò dentro di lui e si riversò fuori con lingue azzurrine. (wrong)
Text after accepting al suggestions: Una forza mostruosa si sollevò dentro M04 e si riversò fuori con lingue azzurrine. (right)
I used the Edit History plugin, which creates a xxx.md.edtz file at the same location as the file. Every time I modify the note, it creates an edit history record (compressed), similar to the commit history of Git.
This quite excellent plugin, obsidian-criticmarkup, also takes effect on this xxx.md.edtz file, making it impossible for me to manage note versions. I suggest that the obsidian-criticmarkup plugin could have an include / exclude mechanism so that I can choose which files to take effect / not take effect.
The compressed edit history was unexpectedly captured by obsidian-criticmarkup.
thx :)
First of all thank you so much for developing this plugin! I am really looking forward to this!
Currently, I modified the obsidian comment to be shown like in this picture, which sadly leads to an issue when having an internal link inside it.
Is it possible to style the comments in a similar but functional way? At least in a future release?
Currently, when using the command to mark as comment without selecting text, the cursor is moved behind the comment markup whereas it would make sense to have it inside the markup.
Description: “comment gutter fold button” didn't show and I can't add content of the new comment because the area didn't show up. I have close all plugins and css snippets, and change to default theme. After I restarted obsidian, It also didn't show.
Then I open the developer console. The operations about comment didn't return any information in the console.
However, when I open a new vault which has some plugins and css snippets, the button shows up. I don't know why.
another issue, when I use the command "mark as comment", it becomes like this:
plugin_version: "0.2.0"
platform: "windows 11"
framework_version: "1.4.16"
obsidian_version: "1.5.8"
(moving from CriticMarkup/CriticMarkup-toolkit#52)
I installed via BRAT and added a comment ({>>test<<}
) to an existing note. When nothing seemed to change I opened dev tools and saw this error:
Any other config or incantations I need to do to get it working?
This is the corresponding markdown file
Untitled.md
In suggestion mode, if I try to correct what I just wrote and put the cursor on a word I previously wrote, on deletion, the cursor jumps and deletes letters of another word. Sam happens when I try to delete the last word I just wrote, the cursor jumps to a previous word. Also, the appa froze.
plugin_version: "0.2.0"
platform: "Desktop"
framework_version: "1.5.8"
obsidian_version: "1.5.11"
Hi fevol!
Steps to reproduce:
Issue: step 4 should not be rendering the critic markup in reading mode.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.