GithubHelp home page GithubHelp logo

Comments (1)

cakoose avatar cakoose commented on June 3, 2024

More serious variant of the issue:

  const subExpr = () => {
    return db.test.a.or(db.test.b);
  }
  await db
    .select(db.test.a)
    .from(db.test)
    .where(db.test.xyz.and(subExpr());
  await db
    .select(db.test.a)
    .from(db.test)
    .where(subExpr().and(db.test.xyz)));
SELECT test.a FROM test WHERE test.xyz AND test.a OR test.b 
SELECT test.a FROM test WHERE test.a OR test.b AND test.xyz 

I would expect the OR to be parenthesized because it is deeper in the function call tree:

SELECT test.a FROM test WHERE test.xyz AND (test.a OR test.b)
SELECT test.a FROM test WHERE (test.a OR test.b) AND test.xyz 

Without that, it makes it hard to reliably write functions that return subexpressions.

Code Sandbox: link

from mammoth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.