Execution of ApplicationController filters about letter_opener_web

[mauro-ni]

@ciihla at the moment I skip filters using an initializer with the following code:

Rails.application.config.to_prepare do
    begin
        LetterOpenerWeb::LettersController.skip_before_action :filter1, :filter2
    rescue NameError
        Rails.logger.info 'Gem letter_opener_web is not installed, therefore cannot be configured!'
    end
end

It could be useful to let the developer choose the behaviour through a letter_opener_web config parameter. This way one may choose between extending own application controller or not.

What do you think?

Mauro

EDIT: handle the case when the gem is not installed (eg. production env)

[ciihla]

You can skip filters in ApplicationController if defined?(LetterOpenerWeb::LettersController) && is_a?(LetterOpenerWeb::LettersController)
Or fork the gem end extend class LettersController < LetterOpenerWeb::ApplicationController
That should solve your problem..

[mauro-ni]

Pull request #78

[pseudomuto]

Sorry for the delay everyone...please feel free to ping me in PRs and issues in the future so I get notified.

[pseudomuto]

Resolved by #82