GithubHelp home page GithubHelp logo

Comments (4)

dlouzan avatar dlouzan commented on August 10, 2024

/cc @bufferoverflow

from letter_opener_web.

fgrehm avatar fgrehm commented on August 10, 2024

Hey!

Sorry for the long delay here. Did you figure this one out? If not, mind creating a minimal app that reproduces the problem? I might be able to take a look. Cheers!

from letter_opener_web.

dlouzan avatar dlouzan commented on August 10, 2024

Hey @fgrehm thanks for the answer. We implemented the support for S/MIME in Gitlab, though without previews 😅

I actually can provide you a fixture signed email that you can load with the Mail gem and use for your tests, just uploaded one in another MR under https://gitlab.com/gitlab-org/gitlab/-/blob/886e0213ab941ced894dc5de178468094111a5f9/spec/fixtures/emails/valid_reply_signed_smime.eml:

pry(main)> email = Mail.new(File.binread('./spec/fixtures/emails/valid_reply_signed_smime.eml'))
=> #<Mail::Message:70331044711260, Multipart: true, Headers: <Date: Mon, 17 Feb 2020 22:56:47 +0100>, <From: "Louzan Martinez, Diego (ext) (SI BP R&D ZG)" <[email protected]>>, <To: Administrator / htmltest <[email protected]>>, <Message-ID: <[email protected]>>, <In-Reply-To: <[email protected]>>, <References: <[email protected]> <[email protected]> <[email protected]>>, <Subject: Re: htmltest | test issue (#1)>, <Mime-Version: 1.0>, <Content-Type: multipart/signed; protocol="application/pkcs7-signature";  micalg=sha256;  boundary="B_3664825007_1904734766">, <User-Agent: Microsoft-MacOutlook/10.22.0.200209>, <Thread-Topic: htmltest | test issue (#1)>>

pry(main)> email.multipart?
=> true

pry(main)> email.parts.map(&:content_type)
=> ["multipart/mixed; boundary=B_3664825007_384940722", "application/pkcs7-signature; name=smime.p7s"]

pry(main)> email.parts[0].part.map(&:content_type)
=> ["multipart/alternative; boundary=B_3664825007_1519466360",
 "image/png; name=gitlab_logo.png; x-mac-creator=4F50494D; x-mac-type=504E4766",

pry(main)> email.parts[0].parts[0].parts.map(&:content_type)
=> ["text/plain; charset=UTF-8", "text/html; charset=UTF-8"]

from letter_opener_web.

fgrehm avatar fgrehm commented on August 10, 2024

Hey @dlouzan! Sorry for the long delay here. Unfortunately I'm not sure how to make that .eml be translated into what letter_opener generates.

I'm not sure if this is an issue directly here, or the underlying letter_opener engine (or even maybe directly on rails / gitlab). Since gitlab is not giving me much log info, I'm not sure where to tackle this.

I guess I didn't pay enough attention to your msg in the first place (sorry about that!) but the rendered email we see on the right side of that screen is really just the .html generated by letter_opener (usually found under tmp/letter_opener). If the HTML is coming back blank I guess there's nothing much we can do on this project :-(

Would you mind opening an issue with letter_opener? Happy to help once we have an example application to try things out. For now will just close this issue but we can continue the discussion if you want to bounce some ideas before opening that issue :-)

Cheers!

from letter_opener_web.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.