fhir / fhir-test-cases Goto Github PK

validator/profile-slicing-coding-bad.json and validator/profile-slicing-coding-good.json have the same value for Observation.id

Please add tests for supplement code system and valueset into https://github.com/FHIR/fhir-test-cases/tree/master/tx

There are couple of things in test case t13 (t13-expected.xml) which I find suspicious. They seem wrong to me, but I could be mistaken.

It looks like slices for code and period (which come from http://hl7.org/fhir/extension-patient-nationality.json.html profile) are not merged correctly into "Patient.extension:complex.

Here is the list of things which I think are not correct for code slice:

1. Short and definition read "Nationality" and "The nationality of the patient." instead of "Nationality Code" and "Code representing nationality of patient." (as per profile).
2. max reads "*" whereas in nationality profile it reads "1".
3. Few other minor things (like presence of "condition" which shouldn't be there, "isSummary" is not present but should be false.

Same thing for period.

It looks like these slices (which are slices on Extension.extension coming from http://hl7.org/fhir/StructureDefinition/patient-nationality) get merged from Extension root.

Am I missing something?